EnterKeyHandling test failure on chrome/win

[bill]

editor/tests/robot/EnterKeyHandling.html has failed on chrome since a long time ago, getting six errors, since before [23300]. The errors started in [23268].

When I roll back even further to anything before [23032], the test won't even load (the browser window is pure white), but that's probably unrelated.

[Jared Jurkiewicz]

It passes for me when I run it on Chrome (Mac): 1 tests to run in 1 groups

------------------------------------------------------------ GROUP "dijit.tests.editor.robot.EnterKeyHandling?" has 1 test to run 13 tests to run in 2 groups ------------------------------------------------------------ GROUP "blockNodeForEnter=BR" has 4 tests to run PASSED test: ../../dijit/tests/editor/robot/EnterKeyHandling.html::blockNodeForEnter=BR::wait for editors to load 2 ms PASSED test: ../../dijit/tests/editor/robot/EnterKeyHandling.html::blockNodeForEnter=BR::type in some text 6635 ms PASSED test: ../../dijit/tests/editor/robot/EnterKeyHandling.html::blockNodeForEnter=BR::copy and paste 6105 ms PASSED test: ../../dijit/tests/editor/robot/EnterKeyHandling.html::blockNodeForEnter=BR::copy and paste split 8105 ms ------------------------------------------------------------ GROUP "Split tests" has 9 tests to run PASSED test: ../../dijit/tests/editor/robot/EnterKeyHandling.html::Split tests::Test div line split 2804 ms PASSED test: ../../dijit/tests/editor/robot/EnterKeyHandling.html::Split tests::Test div line split style clone 2804 ms PASSED test: ../../dijit/tests/editor/robot/EnterKeyHandling.html::Split tests::Test div line split font clone 2804 ms PASSED test: ../../dijit/tests/editor/robot/EnterKeyHandling.html::Split tests::copy and paste DIV 6113 ms PASSED test: ../../dijit/tests/editor/robot/EnterKeyHandling.html::Split tests::copy and paste DIV split 8104 ms PASSED test: ../../dijit/tests/editor/robot/EnterKeyHandling.html::Split tests::Test p line split 2804 ms PASSED test: ../../dijit/tests/editor/robot/EnterKeyHandling.html::Split tests::shift enter to replace all content in p 1505 ms PASSED test: ../../dijit/tests/editor/robot/EnterKeyHandling.html::Split tests::copy and paste P 6105 ms PASSED test: ../../dijit/tests/editor/robot/EnterKeyHandling.html::Split tests::copy and paste P split 8105 ms PASSED test: ../../dijit/tests/editor/robot/EnterKeyHandling.html 76420 ms WOOHOO!! ------------------------------------------------------------ | TEST SUMMARY: ------------------------------------------------------------

14 tests in 1 groups 0 errors 0 failures

I'll try a few more things, but right now I'm marking this as worksforme

[Jared Jurkiewicz]

Just ran it alone, and the full suite, and I don't get any failures in EnterKeyHandling? at all. I'm running Chrome 17.0.963.56, on OS-X. I'll try windows next.

[Jared Jurkiewicz]

This only occurs on windows. For some reason ctrl-a is selecting all and somehow getting a blank *space* or maybe a newline from the document, so that when typing is done, it linebreaks. Very very odd.

[Jared Jurkiewicz]

And I'm not quite sure how to fix that, to be honest. Digging around.

[Jared Jurkiewicz]

This is truly bizarre. After debugging, I can conclude that select-all, copy, then paste, on windows, is somehow injecting a newline as the first character of the pasted string, even though there was no newline in the document at the time of copy. Basically, Google Chrome is injecting an extra character, only on Windows.

I can patch the test to avoid this, but I'm not sure it's the right thing to do.

[Jared Jurkiewicz]

Opened issue with the Google Chrome Forum: ​http://www.google.com/support/forum/p/Chrome/thread?tid=551c4b2ce86e46b3&hl=en&fid=551c4b2ce86e46b30004b92f3ef41208

[bill]

It would be good to patch the test in the meantime, if only to disable these copy-and-paste tests when dojo.isWebKit && !dojo.isMac.

Otherwise we just start to ignore all failures.

[Jared Jurkiewicz]

The bug is apparently known to the Chrome developers: ​http://code.google.com/p/chromium/issues/detail?id=106551

[Jared Jurkiewicz]

In [28031]:

Work around known Chrome bug (Chrome 19 theoretically fixes it.). fixes #14824

[Jared Jurkiewicz]

In [28034]:

Work around known Chrome bug (Chrome 19 theoretically fixes it.) (Had an extra newline check. Removed.). fixes #14824

[bill]

Note that I broke Chrome again in [28413], but I'll fix that and track it in #15216.