Opened 7 years ago

Closed 7 years ago

Last modified 7 years ago

#14810 closed enhancement (fixed)

priority for determining bootstrap deps and callback is incorrect in loader

Reported by: Rawld Gill Owned by: Rawld Gill
Priority: undecided Milestone: 1.8
Component: Loader Version: 1.7.2rc1
Keywords: Cc: ben hockey
Blocked By: Blocking:

Description

the code 

var
  bootDeps = defaultConfig.deps || userConfig.deps || dojoSniffConfig.deps,
  bootCallback = defaultConfig.callback || userConfig.callback || dojoSniffConfig.callback;

seems to get the priorities wrong. The loader should prefer sniff to userConfig to defaultConfig

Change History (5)

comment:1 Changed 7 years ago by Rawld Gill

Status: new → assigned

comment:2 Changed 7 years ago by ben hockey

Cc: ben hockey added

comment:3 Changed 7 years ago by Rawld Gill

Resolution: → fixed
Status: assigned → closed

In [28360]:

reversed priority of boot params from defaultConfig, userConfig, dojoSniffConfig; added tests; fixes #14810; !strict

comment:4 Changed 7 years ago by Rawld Gill

In [28361]:

try [28360] again since error in commit missed files; fixes #14810; !strict

comment:5 Changed 7 years ago by bill

Milestone: tbd → 1.8

Bulk update for closed tickets marked as tbd/future. Presumably these should be marked as fixed in 1.8.

Note: See TracTickets for help on using tickets.