Opened 9 years ago
Closed 9 years ago
#14801 closed enhancement (fixed)
webkitMobile build profile
Reported by: | bill | Owned by: | Rawld Gill |
---|---|---|---|
Priority: | undecided | Milestone: | 1.8 |
Component: | DojoX Mobile | Version: | 1.7.2rc1 |
Keywords: | Cc: | Rawld Gill, ykami, Eric Durocher | |
Blocked By: | #14286, #14792 | Blocking: |
Description
Remove webkitMobile build pragmas and replace with a webkitMobile build profile that strips has("ie"), has("mozilla") etc. code from the build, and hardwires has("webkit") --> true.
Usage will be:
./build.sh releaseDir=... action=release optimize=closure profile=webkitMobile
Change History (15)
comment:1 Changed 9 years ago by
Cc: | Rawld Gill ykami added |
---|---|
Milestone: | tbd → 1.8 |
Owner: | changed from ykami to bill |
Status: | new → assigned |
comment:2 Changed 9 years ago by
Blocked By: | 14286, 14792 added |
---|
comment:3 Changed 9 years ago by
Blocked By: | 14286 removed |
---|
comment:4 Changed 9 years ago by
comment:8 Changed 9 years ago by
Cc: | Eric Durocher added |
---|
comment:10 Changed 9 years ago by
Blocked By: | 14286 added |
---|
comment:11 Changed 9 years ago by
Resolution: | → fixed |
---|---|
Status: | assigned → closed |
comment:12 Changed 9 years ago by
Resolution: | fixed |
---|---|
Status: | closed → reopened |
I spoke too soon. The build is correctly filtering out IE etc. code, but there are other issues. I did a build as:
/build.sh releaseDir=/workspace/amdBuild action=release optimize= layerOptimize= profile=amd copyTests=true
One issue is in browser.js, where the source
if(require.has){ require.has.add("config-selectorEngine", "acme"); }
was built into:
if(require.has){ require. lite || has.add("config-selectorEngine", "acme"); }
This fails since has() is not defined (nor is require.lite).
Rawld, can you take a look? It seems like this is a builder bug/limitation, although admittedly the AMD profile doesn't have this problem.
comment:13 Changed 9 years ago by
Owner: | changed from bill to Rawld Gill |
---|---|
Status: | reopened → assigned |
The other issue is that it's trying to load dojo/lite.js rather than dojo/selector/lite.js, and getting a 404. Seems like an error in webkitMobile.profile but I tried to copy the pattern from the AMD profile so not sure what's causing the different behavior.
In [27883]: