Opened 7 years ago

Closed 7 years ago

#14801 closed enhancement (fixed)

webkitMobile build profile

Reported by: bill Owned by: Rawld Gill
Priority: undecided Milestone: 1.8
Component: DojoX Mobile Version: 1.7.2rc1
Keywords: Cc: Rawld Gill, ykami, Eric Durocher
Blocked By: #14286, #14792 Blocking:

Description

Remove webkitMobile build pragmas and replace with a webkitMobile build profile that strips has("ie"), has("mozilla") etc. code from the build, and hardwires has("webkit") --> true.

Usage will be:

./build.sh releaseDir=... action=release optimize=closure profile=webkitMobile

Change History (15)

comment:1 Changed 7 years ago by bill

Cc: Rawld Gill ykami added
Milestone: tbd1.8
Owner: changed from ykami to bill
Status: newassigned

comment:2 Changed 7 years ago by bill

Blocked By: 14286, 14792 added

comment:3 Changed 7 years ago by bill

Blocked By: 14286 removed

comment:4 Changed 7 years ago by bill

In [27883]:

Remove webkitMobile build pragmas in preparation for webkitMobile build profile. Refs #14801 !strict.

comment:5 Changed 7 years ago by bill

In [27890]:

In progress version of webkitMobile build profile that strips has("ie"), has("mozilla") etc. code from the build, and hardwires has("webkit") --> true. Not working yet (see TODO's in the file).

Usage: ./build.sh releaseDir=... action=release optimize=closure profile=webkitMobile

Refs #14801.

comment:6 Changed 7 years ago by bill

In [28056]:

Add all the has() flags common to webkit mobile browsers. Refs #14801.

comment:7 Changed 7 years ago by ykami

In [28316]:

Refs #14801 !strict. Removed webkitMobile build pragmas from scrollable.js

comment:8 Changed 7 years ago by ykami

Cc: Eric Durocher added

comment:9 Changed 7 years ago by ykami

In [28319]:

Refs #14801 !strict. Removed the webkit option, which is no longer effective, from the build batch files.

comment:10 Changed 7 years ago by bill

Blocked By: 14286 added

comment:11 Changed 7 years ago by bill

Resolution: fixed
Status: assignedclosed

This is now working (because #14792 and #14286 are fixed), and I updated the docs too.

Last edited 7 years ago by bill (previous) (diff)

comment:12 Changed 7 years ago by bill

Resolution: fixed
Status: closedreopened

I spoke too soon. The build is correctly filtering out IE etc. code, but there are other issues. I did a build as:

/build.sh releaseDir=/workspace/amdBuild action=release optimize=  layerOptimize=  profile=amd copyTests=true

One issue is in browser.js, where the source

if(require.has){
        require.has.add("config-selectorEngine", "acme");
}

was built into:

if(require.has){
        require. lite || has.add("config-selectorEngine", "acme");
}

This fails since has() is not defined (nor is require.lite).

Rawld, can you take a look? It seems like this is a builder bug/limitation, although admittedly the AMD profile doesn't have this problem.

comment:13 Changed 7 years ago by bill

Owner: changed from bill to Rawld Gill
Status: reopenedassigned

The other issue is that it's trying to load dojo/lite.js rather than dojo/selector/lite.js, and getting a 404. Seems like an error in webkitMobile.profile but I tried to copy the pattern from the AMD profile so not sure what's causing the different behavior.

comment:14 Changed 7 years ago by bill

In [28557]:

Spacing/spelling etc. fixes to webkitMobile build profile; still has problem with selector engine reference in browser.js, and trying to load dojo/lite.js instead of dojo/selector/lite.js. Refs #14801.

comment:15 Changed 7 years ago by Rawld Gill

Resolution: fixed
Status: assignedclosed

In [28847]:

fixed bug in regex processing of has.add fixups; fixes #14801

Note: See TracTickets for help on using tickets.