Opened 7 years ago
Closed 6 years ago
#14787 closed enhancement (patchwelcome)
update package.json version attribute on branches
| Reported by: | ben hockey | Owned by: | Colin Snover |
|---|---|---|---|
| Priority: | low | Milestone: | tbd |
| Component: | Operations | Version: | 1.7.2rc1 |
| Keywords: | Cc: | ||
| Blocked By: | Blocking: |
Description (last modified by )
should the package.json version attribute be updated on branches by the script that automatically produces a tagged release of dojo.
Change History (5)
comment:1 Changed 7 years ago by
| Blocking: | 14622 added |
|---|---|
| Owner: | changed from rchady to Colin Snover |
| Priority: | undecided → low |
| Status: | new → assigned |
comment:2 Changed 7 years ago by
actually... i noticed this is set for the tagged release but not on the branch. i wonder if we should update versions on the branch before creating tags? if not, then close this ticket.
comment:3 Changed 7 years ago by
| Blocking: | 14622 removed |
|---|
not blocking #14622 since the tagged releases have versions.
comment:4 Changed 7 years ago by
| Description: | modified (diff) |
|---|---|
| Summary: | update package.json version attribute during release → update package.json version attribute on branches |
| Type: | defect → enhancement |
comment:5 Changed 6 years ago by
| Resolution: | → patchwelcome |
|---|---|
| Status: | assigned → closed |
I started trying to do this tonight but I just don’t feel comfortable trying to do this blindly on subversion and I’m not motivated enough to create my own copy of the repo for the purposes of testing the release script. When we do 2.0, it will be much easier to do this. If someone else wants to patch and test the 1.x build_release.sh, please feel free.
assigning to csnover as the release manager for 1.8
marked this as blocking #14622 since being able to properly declare a dependency on a specific version of a package depends on that package being marked with the appropriate version.