dojox.grid.EnhancedGrid + Pagination -- Stack overflow error in IE8

[Seba]

When using dojox.grid.EnhancedGrid? + Pagination plugin + dojox.data.QueryReadStore? I get Stack overflow errors in IE8 after clicking one of the bottom links (pageSizes, pageStepper, gotoButton).

There are no errors when other stores are used.

I will try tu submit 2 files so this error can be reproduced. First one is a modified test file dojox/grid/tests/enchanced/test_enhanced_grid_pagination.html The second one is a test JSON data source for the QueryReadStore?.

My configuration:

OS: Windows XP SP3 HomeEdition? IE: IE 8.0.6001.18702 (The same happens under IE7)

[Seba]

I see no errors under FF3+, Chrome 16, Opera 11.61

[Seba]

The same happens under IE9: 9.0.8112.16421

[Evan]

Working well for me on IE7+, when clicked on any links in the pagination bar, EDG works normally as the snapshot shown. Anything I missed?

[Evan]

working well for me in IE7+

[Seba]

Error under my IE7

[Seba]

Error under my IE8

[Seba]

Well I tested it on 2 different computers under IE7,8,9 and see the same error. This is just a popup message saying "Stack overflow at line 1". after closing the popup each action is completed correctly (pageSizes, pageStepper, gotoButton).

Please check your error console maybe there is something there :)

ps I have couple of IE versions installed on 1 machine. Maybe this couses errors ? I'm using Utilu IE Collection -> ​http://utilu.com/IECollection/

[Seba]

Tested it on another machine without Utilu IE Collection and I see the same error but visible only inside script console. Probably Your IE doesn't display this error inside popup dialog.

[techie]

Tested with Dojo 1.7.x, IE 8, "Out of stack space". While testing with debugger, following line(in dojo.js) has issue

return _384[_385].apply(_384,arguments

[])

Also tested with Firefox 10.0.1(firebug enabled), crashes it completely.

Sample piece of code for enabling pagination in Grid

grid = new dojox.grid.EnhancedGrid?({

id: 'grid', store: store, editable: true, rowsPerPage: 20, structure: layout, plugins: {

pagination: {

description: true, sizeSwitch: true,

pageStepper: true, gotoButton: true, maxPageStep: 4, position: "bottom"

}

}}, document.createElement('div'));

[camts]

With a project specific Store, I have the same error.
I have found it is an infinite loop on Pagination.js line 287 : "_this._originalResize();" that calls itself (line 284 : "g.resize = ...").
Commenting lines 284 to 288 solves the problem in my case, and grid still resizes correctly. Is this "resize" method redefinition really useful ?

[kamalsomani]

this solution works for me. but is it the right way ?

[fsk310]

in Pagination.js

285 near line Replacement for

postCreate: function(){
    this.inherited(arguments);
    var _this = this, g = this.grid;
    this.plugin.connect(g, "_resize", function(){
      _this._resetGridHeight();
    });
    this._originalResize = function(){
      g._resize();
    };
    g.resize = function(changeSize, resultSize){
      _this._changeSize = changeSize;
      _this._resultSize = resultSize;
      _this._originalResize();
    };
    this.focus = _Focus(this);
    this._placeSelf();
  },

[bill]

DojoX Grid and EnhancedGrid are deprecated in favor of ​dgrid and ​gridx.

You should upgrade your code to use one of those two grids.

We will consider patches to the old DojoX Grid code though.