ViewController._parse() searches for a fixed bottom bar, breaks prematurely

[loodwig]

In the ViewController?._parse(text, id) method, the fixed bottom bar is detected and set as the value refNode. The loop that sets the refNode iterates over all children of the target, and "should" break when it finds the nodes that has the property "fixed=bottom". It breaks erroneously the first time it encounters a node that is an element (c.nodeType === 1). Almost always, the bottom fixed UL is the last element on the page. However, this can change if someone scrolls the page using the browser's drag emulator. To solve the problem, place the break element 1 level deeper:

if(c.getAttribute("fixed") === "bottom"){

refNode = c; break;

}

[loodwig]

Diff between 27594 and my suggestion

[ykami]

In [28219]:

Fixes #14708 !strict. Fixed the fixed bottom bar detection logic. Thanks loodwig for the patch.

[ykami]

In [28220]:

Fixes #14708 !strict. Back-port to 1.7. Fixed the fixed bottom bar detection logic. Thanks loodwig for the patch.