Opened 8 years ago

Closed 8 years ago

Last modified 8 years ago

#14708 closed defect (fixed)

ViewController._parse() searches for a fixed bottom bar, breaks prematurely

Reported by: loodwig Owned by: ykami
Priority: high Milestone: 1.8
Component: DojoX Mobile Version: 1.7.1
Keywords: Cc:
Blocked By: Blocking:

Description

In the ViewController?._parse(text, id) method, the fixed bottom bar is detected and set as the value refNode. The loop that sets the refNode iterates over all children of the target, and "should" break when it finds the nodes that has the property "fixed=bottom". It breaks erroneously the first time it encounters a node that is an element (c.nodeType === 1). Almost always, the bottom fixed UL is the last element on the page. However, this can change if someone scrolls the page using the browser's drag emulator. To solve the problem, place the break element 1 level deeper:

if(c.getAttribute("fixed") === "bottom"){

refNode = c; break;

}

Attachments (1)

14708-ViewController.js.diff (364 bytes) - added by loodwig 8 years ago.
Diff between 27594 and my suggestion

Download all attachments as: .zip

Change History (4)

Changed 8 years ago by loodwig

Diff between 27594 and my suggestion

comment:1 Changed 8 years ago by ykami

Milestone: tbd1.8
Priority: undecidedhigh
Status: newassigned

comment:2 Changed 8 years ago by ykami

Resolution: fixed
Status: assignedclosed

In [28219]:

Fixes #14708 !strict. Fixed the fixed bottom bar detection logic. Thanks loodwig for the patch.

comment:3 Changed 8 years ago by ykami

In [28220]:

Fixes #14708 !strict. Back-port to 1.7. Fixed the fixed bottom bar detection logic. Thanks loodwig for the patch.

Note: See TracTickets for help on using tickets.