Opened 10 years ago

Closed 10 years ago

#14706 closed defect (fixed)

[cla] [patch] LazyTreeGrid - onStyleRow blows away customClasses (including default dojoxGridRow class)

Reported by: Karl Tiedt Owned by: Karl Tiedt
Priority: undecided Milestone: 1.8
Component: DojoX Grid Version: 1.7.1
Keywords: Cc:
Blocked By: Blocking:

Description

on line 773 of LazyTreeGrid?.js

​http://bugs.dojotoolkit.org/browser/dojo/dojox/trunk/grid/LazyTreeGrid.js?rev=27713#L773

onStyleRow reassigns row.customClasses so the default dojoxGridRow class is blown away -- including any custom classes assigned through any extension of the Grid

Simple fix is to turn the assignment into a += assignment as such 

row.customClasses += (row.odd ? " dojoxGridRowOdd" : "") + (row.selected ? " dojoxGridRowSelected" : "") + (row.over ? " dojoxGridRowOver" : "");

Change History (2)

comment:1 Changed 10 years ago by Karl Tiedt

Milestone: tbd → 1.8
Owner: changed from Evan to Karl Tiedt
Status: new → assigned

comment:2 Changed 10 years ago by Karl Tiedt

Resolution: → fixed
Status: assigned → closed

In [28451]:

Fixes #14706 - committing this since 3months and still no comments from Evan -- this fix has been running since this ticket was open on a very active project with no additional problems reported.

Note: See TracTickets for help on using tickets.