Opened 8 years ago

Closed 8 years ago

Last modified 7 years ago

#14701 closed defect (fixed)

Menu: Cascading menu is not top aligned the previous menu.

Reported by: siqi Owned by: bill
Priority: undecided Milestone: 1.7.2
Component: Dijit Version: 1.7.1
Keywords: Cc:
Blocked By: Blocking:

Description

The issue can be found in dijit/tests/test_Menu.html. In Dojo 1.6 a cascading menu is top aligned the previous menu. In Dojo 1.7, it seems middle aligned.

Attachments (2)

dojo_1_7_Menu.png (36.0 KB) - added by siqi 8 years ago.
Submenu is middle aligned the previous menu
dojo_1_7_Menu.2.png (36.0 KB) - added by siqi 8 years ago.
Submenu is top aligned the previous menu

Download all attachments as: .zip

Change History (10)

Changed 8 years ago by siqi

Attachment: dojo_1_7_Menu.png added

Submenu is middle aligned the previous menu

Changed 8 years ago by siqi

Attachment: dojo_1_7_Menu.2.png added

Submenu is top aligned the previous menu

comment:1 Changed 8 years ago by bill

Owner: set to Douglas Hays
Status: newassigned
Summary: Cascading menu is not top aligned the previous menu.Menu: Cascading menu is not top aligned the previous menu.

See also http://thread.gmane.org/gmane.comp.web.dojo.user/60722.

Doug - this is fallout from [24439], and has had a number of complaints (ie, this ticket plus the thread I listed above). Can you switch Menu back to use the top alignment?

No one has complained about Tooltip so I'll assume the vertical centering there is an improvement.

comment:2 Changed 8 years ago by Douglas Hays

Milestone: tbd1.7.2

comment:3 Changed 8 years ago by Douglas Hays

Owner: changed from Douglas Hays to bill

Menu worked OK until [24482].

comment:4 Changed 8 years ago by bill

Yes, it's a combination of those two changes, although [24439] is the one that changed the definition (i.e. the behavior) of "before" and "after".

Anyway, I'll revert "before" and "after" to function as they originally did, and make new "before-centered" and "after-centered" settings for the new behavior.

comment:5 Changed 8 years ago by bill

Resolution: fixed
Status: assignedclosed

In [27718]:

Make "before" and "after" positioning (used for submenus) work like in 1.6, where it would align either the tops or bottoms of the anchor and popup. Add "before-centered"and "after-centered" options to be used for Tooltips. Fixes #14701 !strict on trunk/

comment:6 Changed 8 years ago by bill

In [27719]:

Make "before" and "after" positioning (used for submenus) work like in
1.6, where it would align either the tops or bottoms of the anchor and
popup. Add "before-centered"and "after-centered" options to be used for
Tooltips. Fixes #14701 !strict on 1.7/ branch.

comment:7 Changed 8 years ago by cjolif

In [27808]:

refs #14701. Had to change charting tooltip position from after/before to after-centered/before-centered to prevent tooltip from displaying wrongly located arrows. !strict.

comment:8 Changed 7 years ago by cjolif

In [28128]:

refs #14701. Had to change more tooltip positions (from after/before to centered-* to avoid tooltip issues with Pie.

Note: See TracTickets for help on using tickets.