Opened 8 years ago

Closed 8 years ago

#14700 closed defect (fixed)

_DataBindingMixin.updateChildBindings doesn't update all children widgets

Reported by: superbird Owned by: Ed Chatelain
Priority: high Milestone: 1.7.2
Component: DojoX MVC Version: 1.7.1
Keywords: Cc:
Blocked By: Blocking:

Description

_getParentBingFromDOM will traverse upwards until it finds the first ancestor widget with binding. It skips any intermediate widgets that don't have binding. updateChildBinding only traverse downwards through children that have binding. The behavior is asymmetrical. It should also skip child widgets that don't have binding.

Attachments (2)

mvc-14700.patch (2.7 KB) - added by Ed Chatelain 8 years ago.
Fix to _DataBindingMixin and a change to a testcase to cover it. For trunk.
mvc-14700-1.7Branch.patch (2.7 KB) - added by Ed Chatelain 8 years ago.
Fix to _DataBindingMixin and a change to a testcase to cover it. For the 1.7 Branch.

Download all attachments as: .zip

Change History (6)

comment:1 Changed 8 years ago by Ed Chatelain

Priority: undecidedhigh
Status: newassigned

Changed 8 years ago by Ed Chatelain

Attachment: mvc-14700.patch added

Fix to _DataBindingMixin and a change to a testcase to cover it. For trunk.

Changed 8 years ago by Ed Chatelain

Attachment: mvc-14700-1.7Branch.patch added

Fix to _DataBindingMixin and a change to a testcase to cover it. For the 1.7 Branch.

comment:2 Changed 8 years ago by cjolif

In [27720]:

refs #14700. Thanks edchat. !strict.

comment:3 Changed 8 years ago by cjolif

Milestone: tbd1.7.2

comment:4 Changed 8 years ago by cjolif

Resolution: fixed
Status: assignedclosed

In [27721]:

fixes #14700. Thanks edchat.

Note: See TracTickets for help on using tickets.