Opened 13 years ago

Closed 13 years ago

Last modified 12 years ago

#1470 closed defect (worksforme)

small gap in remotely loaded TabContainer panels

Reported by: erickt@… Owned by: bill
Priority: high Milestone:
Component: Widgets Version: 0.3
Keywords: Cc:
Blocked By: Blocking:

Description

On both safari and firefox I have a sizable gap between the top of a remotely loaded pane, and where the tab list is. There isn't this gap on locally created tabs, which makes for an inconsistant interface. This can be seen here:

http://archive.dojotoolkit.org/nightly/tests/widget/test_TabContainer.html

I found that if you remove the lines that reference the class "dojoTabPane" (as seen in the attached diff), this gap goes away. Is there any reason why this class is in there, and if so, is there an alternative way to have this so that the gap doesn't appear?

Attachments (1)

TabContainer.patch (718 bytes) - added by erickt@… 13 years ago.
example fix for the tab gap problem

Download all attachments as: .zip

Change History (4)

Changed 13 years ago by erickt@…

Attachment: TabContainer.patch added

example fix for the tab gap problem

comment:1 Changed 13 years ago by erickt@…

Milestone: 0.4

comment:2 Changed 13 years ago by bill

Resolution: worksforme
Status: newclosed
Version: 0.3

yeah, i'm not sure if it makes sense to tag each child as dojoTabPane or not, but in the latest code I don't see the problem you described, and I also don't see any CSS rules at all for .dojoTabPane. If there was such a rule you could easily override it by saying something like

body .dojoTabPane { margin: 0; padding: 0; }

in your CSS file.

comment:3 Changed 12 years ago by (none)

Milestone: 0.4

Milestone 0.4 deleted

Note: See TracTickets for help on using tickets.