Opened 8 years ago

Closed 4 years ago

#14680 closed defect (patchwelcome)

BusyButton runs makeBusy when disabled

Reported by: kermiedefrog Owned by: Kitson Kelly
Priority: undecided Milestone: 1.13
Component: DojoX Form Version: 1.7.1
Keywords: Cc:
Blocked By: Blocking:

Description

the private _onClick only checks ifBusy and doesn't check if button already disabled. As a result makeBusy() goes through the process states of the busybutton and finishes with the button being enabled when it should still be in a disabled state... a check should be made at this point to check if the button is already disabled at the same time... NOTE: when disabled it does NOT run the onClick method which is the correct behaviour, it just changes the button state which is not the correct behaviour...

Change History (4)

comment:1 Changed 8 years ago by bill

Component: GeneralDojoX Widgets
Owner: set to dante

comment:2 Changed 8 years ago by bill

Component: DojoX WidgetsDojoX Form

comment:3 Changed 7 years ago by Kitson Kelly

Owner: changed from dante to Kitson Kelly
Status: newassigned

comment:4 Changed 4 years ago by dylan

Milestone: tbd1.12
Resolution: patchwelcome
Status: assignedclosed

Given that no one has shown interest in creating a patch in the past 3+ years, I'm closing this as patchwelcome.

Note: See TracTickets for help on using tickets.