Opened 8 years ago

Closed 8 years ago

Last modified 8 years ago

#14670 closed defect (fixed)

dijit/InlineEditBox AMD+MID editor inconsistency

Reported by: Maastermedia Owned by: bill
Priority: undecided Milestone: 1.8
Component: Dijit Version:
Keywords: Cc:
Blocked By: Blocking:

Description

http://livedocs.dojotoolkit.org/dijit/InlineEditBox#markup

current declarative usage is using:

data-dojo-props="editor: 'dijit.form.NumberSpinner'"

It should probably use something like:

data-dojo-props="editor: 'dijit/form/NumberSpinner'"

Change History (3)

comment:1 Changed 8 years ago by bill

Milestone: tbd1.8
Owner: set to bill
Status: newassigned

FYI, I think the most basic support is (or should be) that editor is a constructor, ex:

require["dijit/InlineEditBox", "dijit/form/NumberSpinner"],
function(InlineEditBox, NumberSpinner){
   new InlineEditBox({editor: NumberSpinner});
});

But for declarative I agree it's useful to be able to pass in an MID, as in your example above.

comment:2 Changed 8 years ago by bill

Resolution: fixed
Status: assignedclosed

In [27685]:

Allow specifying MID for InlineEditBox.editor rather than global variable. Fixes #14670, refs #13778 !strict.

comment:3 Changed 8 years ago by bill

I added that feature, although I do wonder if users should just be doing:

data-dojo-props="editor: require('dijit/form/NumberSpinner')"
Note: See TracTickets for help on using tickets.