Opened 13 years ago

Closed 13 years ago

Last modified 12 years ago

#1464 closed defect (fixed)

[patch][cla] TitlePane content area maintains spacing when closed

Reported by: jhitt@… Owned by: dylan
Priority: high Milestone:
Component: Widgets Version: 0.3
Keywords: TitlePane Cc:
Blocked By: Blocking:

Description

When closing a title pane that is not wrapped in a fixed height div, spacing reverts to original height but a blank content area. A patch for this is included below.

*** original/TitlePane.js     2006-09-19 10:06:18.000000000 -0500
--- TitlePane.js   2006-09-19 10:17:17.000000000 -0500
***************
*** 47,56 ****

        onLabelClick: function() {
                if (this.open) {
!                  dojo.lfx.wipeOut(this.containerNode,250).play();
                   this.open=false;
!               }else {
!                  dojo.lfx.wipeIn(this.containerNode,250).play();
                   this.open=true;
                }
        },
--- 47,62 ----

        onLabelClick: function() {
                if (this.open) {
!             var callback = function(node, anim) {
!                 dojo.html.setStyle(node, "position", "absolute");
!             };
!
!             this.height = dojo.html.getStyle(this.containerNode, "height");
!             dojo.lfx.wipeOut(this.containerNode, 250, 5, callback).play();
                   this.open=false;
!               } else {
!             dojo.html.setStyle(this.containerNode, "position", "relative");
!             dojo.lfx.wipeIn(this.containerNode, 250).play();
                   this.open=true;
                }
        },
***************
*** 62,65 ****
--- 68,72 ----
        setLabel: function(label) {
                this.labelNode.innerHTML=label;
        }
+
  });

Attachments (2)

TitlePane.js (1.7 KB) - added by jhitt@… 13 years ago.
Patched version of TitlePane?.js
newPatch.txt (1.6 KB) - added by jhitt@… 13 years ago.
Updated patch accounting for initial closed state. Ignore previous attachment

Download all attachments as: .zip

Change History (6)

Changed 13 years ago by jhitt@…

Attachment: TitlePane.js added

Patched version of TitlePane?.js

comment:1 Changed 13 years ago by dylan

Milestone: 0.4
Owner: changed from bill to dylan
Status: newassigned
Summary: TitlePane content area maintains spacing when closed[patch][need cla] TitlePane content area maintains spacing when closed

I sent a request for cla to email address listed in reporter. If I get that by this weekend, I can get this into 0.4

Changed 13 years ago by jhitt@…

Attachment: newPatch.txt added

Updated patch accounting for initial closed state. Ignore previous attachment

comment:2 Changed 13 years ago by dylan

Summary: [patch][need cla] TitlePane content area maintains spacing when closed[patch][cla] TitlePane content area maintains spacing when closed

comment:3 Changed 13 years ago by dylan

Resolution: fixed
Status: assignedclosed

(In [5798]) fixes #1464, TitlePane? content area maintains spacing when closed, thanks for the patch

comment:4 Changed 12 years ago by (none)

Milestone: 0.4

Milestone 0.4 deleted

Note: See TracTickets for help on using tickets.