Opened 7 years ago

Closed 7 years ago

Last modified 7 years ago

#14638 closed defect (fixed)

dojox.mobile.View should not inherit from dijit._Container

Reported by: ykami Owned by: ykami
Priority: high Milestone: 1.8
Component: DojoX Mobile Version: 1.7.1
Keywords: Cc: Eric Durocher, cjolif
Blocked By: Blocking:

Description

dojox.mobile.View often takes plain text or html as its child. But container-type dijit require all the children to be dojo widgets. So, View should not inherit from dijit._Container. For the same reason, _ItemBase, Heading, and RoundRect should not inherit from dijit._Container either.

Change History (5)

comment:1 Changed 7 years ago by ykami

Resolution: fixed
Status: newclosed

In [27591]:

Fixes #14638 !strict Removed dijit._Container from the widget's base classes.

comment:2 Changed 7 years ago by ykami

In [27631]:

Refs #14638 !strict. Changed addChild() to addFixedBar() since View is not a container any longer.

comment:3 Changed 7 years ago by ykami

Cc: Eric Durocher cjolif added
Resolution: fixed
Status: closedreopened

The dijit policy has been changed. Now dijit_Container can be a superclass for any widget with children, and even dijit.layout.ContentPane was changed to inherit from dijit._Container (#7819). dojox.mobile.View and some others can also inherit from dijit._Container now.

comment:4 Changed 7 years ago by ykami

Resolution: fixed
Status: reopenedclosed

In [28322]:

Fixes #14638 Added dijit._Container back to _ItemBase, Heading, RoundRect?, and View. Changed some of the placeAt calls to addChild. Removed startup calls after placeAt, since placeAt was updated to call startup. !strict

comment:5 Changed 7 years ago by ykami

In [28325]:

Refs #14638 dojox.mobile.ContentPane? should also inherit from dijit._Container. !strict

Note: See TracTickets for help on using tickets.