Opened 8 years ago

Closed 8 years ago

Last modified 8 years ago

#14635 closed enhancement (fixed)

Reconsider the algorithm of hiding address bar

Reported by: Atsushi Ono Owned by: ykami
Priority: high Milestone: 1.8
Component: DojoX Mobile Version: 1.7.1
Keywords: Cc: Eric Durocher
Blocked By: Blocking:

Description

The current algorithm of hiding address bar works fine, but it resets the height of body too wide and it is tried many times even if the address bar is already hidden for fail-safe. We should reconsider the algorithm to make it better.

Attachments (1)

14635-1.patch​ (2.7 KB) - added by Atsushi Ono 8 years ago.
[patch][ccla] 1st patch as a result of reconsideration

Download all attachments as: .zip

Change History (5)

Changed 8 years ago by Atsushi Ono

Attachment: 14635-1.patch​ added

[patch][ccla] 1st patch as a result of reconsideration

comment:1 Changed 8 years ago by Atsushi Ono

The patch will do the followings although it needs more review and testing:

  • Reset the min height of body to an appropriate height which is long enough to hide address bar but not too long
  • Add the function to determine whether the address bar is already hidden or not, so that we can reduce the number of trials to hide address bar

comment:2 Changed 8 years ago by ykami

Milestone: tbd → 1.8
Status: new → assigned

comment:3 Changed 8 years ago by ykami

Resolution: → fixed
Status: assigned → closed

In [27606]:

Fixes #14635 !strict Applied onoat's hide-address-bar patch. Thanks onoat for the patch.

comment:4 Changed 8 years ago by Eric Durocher

Cc: Eric Durocher added
Note: See TracTickets for help on using tickets.