Opened 8 years ago

Closed 7 years ago

#14622 closed defect (fixed)

npm with dijit/dojox fails because of package.json's dojo version

Reported by: kbrowder Owned by: Colin Snover
Priority: blocker Milestone: 1.8
Component: Dijit Version: 1.7.1
Keywords: node npm commonjs package.json Cc: Colin Snover
Blocked By: Blocking:

Description

After npm config set registry packages.dojofoundation.org I do npm install dojo@1.7.1 and things work, however npm install dijit@1.7.1 or dojox fails because npm can't find 'current' versions of npm. According to the commonjs or node standards for package.json there is no "current" keyword; either standard requires a version of some sort. For released tagged versions this should be identical as the version (eg if i do dijit@1.7.1 I should not get dojo>1.7.1). You can see https://github.com/dojo/dijit/blob/1.7.1/package.json:

"dependencies": {

"dojo": "current"

}

Which I think should be "dojo": "1.7.1". Not sure what it should be for dev versions.

Change History (9)

comment:1 Changed 8 years ago by bill

Owner: set to Kris Zyp

comment:2 Changed 8 years ago by ben hockey

Blocked By: 14787 added

(In #14787) assigning to csnover as the release manager for 1.8

marked this as blocking #14622 since being able to properly declare a dependency on a specific version of a package depends on that package being marked with the appropriate version.

comment:3 Changed 7 years ago by Kris Zyp

Resolution: fixed
Status: newclosed

In [29152]:

Assign the correct Dojo version dependency, fixes #14622

comment:4 Changed 7 years ago by bill

Milestone: tbd1.8

comment:5 Changed 7 years ago by kbrowder

Maybe this is a new bug, but package.json hasn't been updated in 1.8.0r1 so I don't think this fix will actually work as expected: https://github.com/dojo/dijit/blob/1.8.0rc1/package.json Has: "dependencies": { "dojo": "1.8.0dev" } Which presumably will make node (or other package managers) try to get dojo 1.8.0dev instead of 1.8.0rc1.

comment:6 Changed 7 years ago by ben hockey

Cc: Colin Snover added

comment:7 Changed 7 years ago by Colin Snover

Priority: highblocker
Resolution: fixed
Status: closedreopened

will ensure this is working for final.

comment:8 Changed 7 years ago by Colin Snover

Owner: changed from Kris Zyp to Colin Snover
Status: reopenedassigned

comment:9 Changed 7 years ago by Colin Snover

Resolution: fixed
Status: assignedclosed

In [29413]:

Add dependencies to dojox package.json and ensure dependency versions are updated in package.json. Fixes #14622.

Note: See TracTickets for help on using tickets.