npm with dijit/dojox fails because of package.json's dojo version

[kbrowder]

After npm config set registry packages.dojofoundation.org I do npm install dojo@1.7.1 and things work, however npm install dijit@1.7.1 or dojox fails because npm can't find 'current' versions of npm. According to the commonjs or node standards for package.json there is no "current" keyword; either standard requires a version of some sort. For released tagged versions this should be identical as the version (eg if i do dijit@1.7.1 I should not get dojo>1.7.1). You can see ​https://github.com/dojo/dijit/blob/1.7.1/package.json:

"dependencies": {

"dojo": "current"

}

Which I think should be "dojo": "1.7.1". Not sure what it should be for dev versions.

[ben hockey]

(In #14787) assigning to csnover as the release manager for 1.8

marked this as blocking #14622 since being able to properly declare a dependency on a specific version of a package depends on that package being marked with the appropriate version.

[Kris Zyp]

In [29152]:

Assign the correct Dojo version dependency, fixes #14622

[kbrowder]

Maybe this is a new bug, but package.json hasn't been updated in 1.8.0r1 so I don't think this fix will actually work as expected: ​https://github.com/dojo/dijit/blob/1.8.0rc1/package.json Has: "dependencies": { "dojo": "1.8.0dev" } Which presumably will make node (or other package managers) try to get dojo 1.8.0dev instead of 1.8.0rc1.

[Colin Snover]

will ensure this is working for final.

[Colin Snover]

In [29413]:

Add dependencies to dojox package.json and ensure dependency versions are updated in package.json. Fixes #14622.