Opened 10 years ago
Closed 8 years ago
#14620 closed defect (wontfix)
benchtool has unnecessary escape() and urldecode() calls
Reported by: | bill | Owned by: | dante |
---|---|---|---|
Priority: | low | Milestone: | future |
Component: | Dijit | Version: | 1.7.1 |
Keywords: | Cc: | ||
Blocked By: | Blocking: |
Description
The escape() call in benchTool.html:
dojo.byId('hiddenHolder').value = escape(dojo.toJson(masterResults));
and then the subsequent urldecode() call in submit.php:
$string = $json->decode(urldecode($_POST['key']));
... are both unnecessary. HTTP handles encoding/decoding for any arbitrary values in form fields, over either a POST or a GET (in this case, it's a POST).
I'll remove the escape() call but I don't have write permission on submit.php.
Change History (4)
comment:1 Changed 10 years ago by
comment:2 Changed 9 years ago by
Priority: | high → low |
---|
comment:3 Changed 9 years ago by
Milestone: | tbd → future |
---|
comment:4 Changed 8 years ago by
Resolution: | → wontfix |
---|---|
Status: | new → closed |
Nowadays people use jsPerf for benchmarking.
Note: See
TracTickets for help on using
tickets.
In [27564]: