Opened 7 years ago

Closed 5 years ago

#14620 closed defect (wontfix)

benchtool has unnecessary escape() and urldecode() calls

Reported by: bill Owned by: dante
Priority: low Milestone: future
Component: Dijit Version: 1.7.1
Keywords: Cc:
Blocked By: Blocking:

Description

The escape() call in benchTool.html: 

dojo.byId('hiddenHolder').value = escape(dojo.toJson(masterResults));

and then the subsequent urldecode() call in submit.php: 

$string = $json->decode(urldecode($_POST['key']));

... are both unnecessary. HTTP handles encoding/decoding for any arbitrary values in form fields, over either a POST or a GET (in this case, it's a POST).

I'll remove the escape() call but I don't have write permission on submit.php.

Change History (4)

comment:1 Changed 7 years ago by bill

In [27564]:

remove unnecessary call to deprecated escape() function, refs #14620

comment:2 Changed 6 years ago by bill

Priority: high → low

comment:3 Changed 6 years ago by bill

Milestone: tbd → future

comment:4 Changed 5 years ago by bill

Resolution: → wontfix
Status: new → closed

Nowadays people use jsPerf for benchmarking.

Note: See TracTickets for help on using tickets.