Opened 8 years ago

Closed 8 years ago

#14608 closed defect (fixed)

UpgradeBar.js should use dijit._TemplatedMixin

Reported by: Brett van de Sande Owned by: Revin Guillen
Priority: low Milestone: 1.8
Component: DojoX Widgets Version: 1.7.1
Keywords: Cc:
Blocked By: Blocking:

Description

For version 2.0, should change dijit._Templated -> dijit._TemplatedMixin

Attachments (1)

patch​ (710 bytes) - added by Brett van de Sande 8 years ago.
patch

Download all attachments as: .zip

Change History (7)

Changed 8 years ago by Brett van de Sande

Attachment: patch​ added

patch

comment:1 Changed 8 years ago by Revin Guillen

In [27545]:

Update UpgradeBar? to AMD, refs #14608

comment:2 Changed 8 years ago by Revin Guillen

Owner: changed from dante to Revin Guillen

I've actually had a full AMD version of UpgradeBar sitting here for a while bug neglected to check it in; it includes the change to _TemplatedMixin and more, so that should be sufficient, I hope.

comment:3 Changed 8 years ago by Revin Guillen

Resolution: → fixed
Status: new → closed

comment:4 Changed 8 years ago by bill

Milestone: tbd → 1.8

comment:5 Changed 8 years ago by ben hockey

Resolution: fixed
Status: closed → reopened

don't forget to update dojox/dojox.profile.js so that these converted files get tagged as amd. ie update the excludes array so that these module ids aren't going to match any more.

comment:6 Changed 8 years ago by Revin Guillen

Resolution: → fixed
Status: reopened → closed

In [28836]:

Mark dojox/widget/UpgradeBar as AMD in the DojoX build profile; fixes #14608.

Note: See TracTickets for help on using tickets.