#14603 closed enhancement (fixed)
allow configuring newline style for build output
Reported by: | Rawld Gill | Owned by: | Rawld Gill |
---|---|---|---|
Priority: | high | Milestone: | 1.8 |
Component: | BuildSystem | Version: | 1.7.1 |
Keywords: | Cc: | ||
Blocked By: | Blocking: |
Description
The build system always uses "\n" for newline when generating output. This may be inconvenient for some editors in some environments. Further, since most of the dojo source contains \r\n for newlines, adding just a few single \n newlines causes the file to have mixed newline styles which further confuses some editors/IDEs. All this combines to make debugging build output painful for some dev environments.
Add a profile configuration variable that overrides the default newline sequence.
Change History (7)
comment:1 Changed 9 years ago by
Resolution: | → fixed |
---|---|
Status: | new → closed |
comment:2 Changed 9 years ago by
Resolution: | fixed |
---|---|
Status: | closed → reopened |
bc.newline
is undefined
with --check-args
command line switch
comment:3 Changed 9 years ago by
I got also
error(324) Error while transforming resource. resource: dojo/dojo.js transform: 5; error: InternalError?: il manque ':' après un identifiant de propriété
And my dojo.js.uncompressed.js containes undefined for newline too
comment:4 Changed 9 years ago by
severity: | normal → critical |
---|
builds completely fail (no dojo.js) silently with this problem so escalating to a higher severity. at first i hadn't noticed this issue until i blew away my release directory and saw that there was no dojo.js
comment:5 follow-up: 7 Changed 9 years ago by
rawld, i believe the circular dependency from buildControl -> stringify -> buildControl is causing the problem. the buildControl factory is not being executed.
comment:7 Changed 9 years ago by
Replying to neonstalwart:
rawld, i believe the circular dependency from buildControl -> stringify -> buildControl is causing the problem. the buildControl factory is not being executed.
Thanks Ben! That seemed to be it re the check-args.
I don't understand why dojo.js wasn't building...that was working on my machine. Maybe I've got a local condition that causes that error to not be seen. Let me know if you see further problems.
In [27542]: