Opened 7 years ago

Closed 7 years ago

Last modified 7 years ago

#14603 closed enhancement (fixed)

allow configuring newline style for build output

Reported by: Rawld Gill Owned by: Rawld Gill
Priority: high Milestone: 1.8
Component: BuildSystem Version: 1.7.1
Keywords: Cc:
Blocked By: Blocking:

Description

The build system always uses "\n" for newline when generating output. This may be inconvenient for some editors in some environments. Further, since most of the dojo source contains \r\n for newlines, adding just a few single \n newlines causes the file to have mixed newline styles which further confuses some editors/IDEs. All this combines to make debugging build output painful for some dev environments.

Add a profile configuration variable that overrides the default newline sequence.

Change History (7)

comment:1 Changed 7 years ago by Rawld Gill

Resolution: fixed
Status: newclosed

In [27542]:

added profile switch 'newline' which may be used to override the default newline sequence ('\n') for generated output during a build; fixes #14603; !strict

comment:2 Changed 7 years ago by ben hockey

Resolution: fixed
Status: closedreopened

bc.newline is undefined with --check-args command line switch

ben@dev04 ~/svn/dojo/util » buildscripts/build.sh -p base --check-args
processing profile resource /homes/staff/ben/svn/dojo/util/buildscripts/profiles/base.profile.js
{profiles:[{undefined                                    basePath:"/homes/staff/ben/svn/dojo/util/buildscripts",undefined                                        defaultConfig:{hasCache:{}},undefined                                   layers:{},undefined                                     packages:[{undefined                                                  copyright:"/*\n\tCopyright (c) 2004-2011, The Dojo Foundation All Rights Reserved.\n\tAvailable via Academic Free License >= 2.1 OR the modified BSD license.\n\tsee: http://dojotoolkit.org/license for details\n*/\n\n",undefined              location:"/homes/staff/ben/svn/dojo/dojo",undefined                                                                    name:"dojo",undefined                                                                    runtime:undefinedundefined      }],undefined                                     releaseDir:"/homes/staff/ben/svn/dojo/release",undefined               releaseName:"dojo",undefined                                     selfFilename:"/homes/staff/ben/svn/dojo/util/buildscripts/profiles/base.profile.js",undefined                                   staticHasFeatures:{}undefined                 }]}
ben@dev04 ~/svn/dojo/util »
Last edited 7 years ago by ben hockey (previous) (diff)

comment:3 Changed 7 years ago by Mathevet julien

I got also

error(324) Error while transforming resource. resource: dojo/dojo.js transform: 5; error: InternalError?: il manque ':' après un identifiant de propriété

And my dojo.js.uncompressed.js containes undefined for newline too

comment:4 Changed 7 years ago by ben hockey

severity: normalcritical

builds completely fail (no dojo.js) silently with this problem so escalating to a higher severity. at first i hadn't noticed this issue until i blew away my release directory and saw that there was no dojo.js

comment:5 Changed 7 years ago by ben hockey

rawld, i believe the circular dependency from buildControl -> stringify -> buildControl is causing the problem. the buildControl factory is not being executed.

comment:6 Changed 7 years ago by Rawld Gill

Resolution: fixed
Status: reopenedclosed

In [27575]:

fixed circular dependency in stringify; fixes #14603; !strict

comment:7 in reply to:  5 Changed 7 years ago by Rawld Gill

Replying to neonstalwart:

rawld, i believe the circular dependency from buildControl -> stringify -> buildControl is causing the problem. the buildControl factory is not being executed.

Thanks Ben! That seemed to be it re the check-args.

I don't understand why dojo.js wasn't building...that was working on my machine. Maybe I've got a local condition that causes that error to not be seen. Let me know if you see further problems.

Note: See TracTickets for help on using tickets.