Opened 8 years ago

Closed 7 years ago

Last modified 7 years ago

#14598 closed defect (fixed)

dojox.mobile.ToolBarButton should be inline style

Reported by: ykami Owned by: ykami
Priority: high Milestone: 1.8
Component: DojoX Mobile Version: 1.7.1
Keywords: Cc:
Blocked By: Blocking:

Description

The current ToolBarButton is made from <div> and act as a block element. But it is kind of a form control, and often used with text. So, it should be inline style rather than block style.

Change History (8)

comment:1 Changed 8 years ago by ykami

In [27600]:

Refs #14642 #14598 !strict. Added support for arrow shape button to be able to be used as a back button in Heading. Use the table tag to make the widget inline type. Added icon support.

comment:2 Changed 8 years ago by ykami

In [27601]:

Refs #14642 #14598 !strict. ToolBarButton? style updates.

comment:3 Changed 8 years ago by ykami

In [27804]:

Refs #14598 !strict Produces a span element when the button has only an icon. Fixed the styles accordingly. Added a new test file.

comment:4 Changed 8 years ago by ykami

In [27809]:

Refs #14598 !strict Reverted the last changes.

comment:5 Changed 8 years ago by ykami

In [27810]:

Refs #14598 !strict ToolBarButton? style updates. Improvement of the back button appearance to be more iOS-like look is based on Nicola Rizzo[CLA]'s patch. Thank you Nicola for the patch.

comment:6 Changed 7 years ago by ykami

Resolution: fixed
Status: newclosed

In [28013]:

Fixes #14598 !strict Changed the domNode from <table> to <span> to simplify the dom structure.

comment:7 Changed 7 years ago by ykami

In [28014]:

Refs #14598 !strict Changed the tags for ToolBarButton? from <button> to <span>.

comment:8 Changed 7 years ago by cjolif

In [29430]:

fixes #15675, fixes Maqetta issue without creating regressions this time (Thanks Kamiyama, Adrian & Damien). refs #14598, #15400. !strict.

Note: See TracTickets for help on using tickets.