Changes between Initial Version and Version 1 of Ticket #14591, comment 14


Ignore:
Timestamp:
Jan 29, 2012, 12:31:14 PM (7 years ago)
Author:
Kitson Kelly
Comment:

Legend:

Unmodified
Added
Removed
Modified
  • Ticket #14591, comment 14

    initial v1  
    11There was some changes that needed to be made to the patch that fixes issues with `dijit/_WidgetsInTemplate` and `.stopParser`, also some other minor modifications to get rid of some regressions (like `dijit/Declaration`).  I think I caught them all, but in particular, the `.stopParser` performance changes (but very oddly between Chrome and IE for some reason).  I am also explicit about which query selector we are using.
    22
    3 I also attempted to re-implement the `_hasSpecialAttrs` in this patch, but the overhead to figure that out significantly outweighed just doing it.  It is overhead though that is just not needed for 99% of folks out there.  I am going to open another feature request to start to support the concept of overriding the type of parser being used, both through the options and the require parameters format.  That way end developers will default to current situation, but anyone who wants to can just shut off the support for it.
     3I also attempted to re-implement the `_hasSpecialAttrs` in this patch, but the overhead to figure that out significantly outweighed just doing it.  It is overhead though that is just not needed for 99% of folks out there.  I opened another feature request (#14691) to start to support the concept of overriding the type of parser being used, both through the options and the require parameters format.  That way end developers will default to current situation, but anyone who wants to can just shut off the support for it.
    44
    55Here is what I have from a performance perspective: