Opened 8 years ago

Closed 8 years ago

Last modified 8 years ago

#14586 closed defect (fixed)

Undocumented libraries in the builder Closure JAR

Reported by: benkrembs Owned by: Rawld Gill
Priority: high Milestone: 1.8
Component: BuildSystem Version: 1.7.1
Keywords: builder Cc:
Blocked By: Blocking:

Description

Either the Closure JAR included with the build is a version that's no longer generally available, or it's a custom JAR that merges together several Google projects. It might be useful to either replace with the stock libraries or document the ones that are included.

I discovered this when I tried replacing the Closure JAR with the latest Closure download (through Maven dependency management) and noticed some missing classes. After sorting through several missing class exceptions, I've created a working list of libraries and believe the Dojo JAR is actually a combination of the below 3 projects and versions.

<dependency>

<groupId>com.google.javascript</groupId>

<artifactId>closure-compiler</artifactId> <version>r1592</version>

</dependency>

<dependency>

<groupId>com.google.guava</groupId> <artifactId>guava</artifactId> <version>11.0</version>

</dependency> <dependency>

<groupId>com.google.protobuf</groupId> <artifactId>protobuf-java</artifactId> <version>2.4.1</version>

</dependency>

And, of course, there's the Rhino dependency (if that's how one rolls)

<dependency>

<groupId>rhino</groupId> <artifactId>js</artifactId> <version>1.7R2</version>

</dependency>

Change History (4)

comment:1 Changed 8 years ago by benkrembs

UPDATE -- for anybody else going through this, the above doesn't work. Although it appears to complete successfully, there are a some minified JS files that are blank (with the exception of "built" at the top).

I believe this is due to either missing JAR libraries, some incompatibility with the versions I've got in there, etc and an error is being squelched.

So a more accurate title for this bug is the fact that the build only works with the Dojo distribution of Rhino and Closure.

comment:2 Changed 8 years ago by Rawld Gill

Resolution: fixed
Status: newclosed

In [27535]:

updated closure compiler; fixes #14586

comment:3 Changed 8 years ago by Rawld Gill

The closure version committed in [27535] is from http://closure-compiler.googlecode.com/files/compiler-latest.zip on 11 JAN 2012

comment:4 Changed 8 years ago by bill

Milestone: tbd1.8
Note: See TracTickets for help on using tickets.