node.js detection broken on Linux

[MaxMotovilov]

​https://github.com/dojo/dojo/commit/2abfde8208260b838fcf63844a9a276c251c3ca1

Some improvement... typical installation (nodejs deb package on Ubuntu in my case) results in

process.exePath=='/usr/bin/nodejs'

and the current detection regex misses that. Rolling this commit back should do the trick

[bill]

The problem is that the executable is called nodejs instead of node?

[Eugene Lazutkin]

The problem is the code tries to detect the name of a process, which is brittle, and error-prone (see navigator.userAgent and associated problems). It is much safer to detect an environment, or prominent features, instead of superficial features like OS-dependent process information.

Some detection variants are listed on SO: ​http://stackoverflow.com/questions/4224606/how-to-check-whether-a-script-is-running-under-node-js

[Rawld Gill]

In [27537]:

improved node detection; fixes #14540; !strict

[Rawld Gill]

In [27538]:

fixed typo; fixes #14540; !strict

[Rawld Gill]

In [27539]:

improved node.js detection to prefer user config (if available); refs #14540; !strict

[Rawld Gill]

Thanks for attending to this Eugene!

I improved the sniff so that I can't see how looking at the executable is still necessary; also allow explicit user override.

Here is an example node.js program that uses the override

global.dojoConfig = {
  has:{
    "host-node":1
  }
};
require("path/to/dojo.js");

This program could be executed [e.g.] by the command line...

node path/to/example/above.js load=some/module/to/load

Of course the load= is optional

Tested with node renamed to nodex on linux...all seems good.

[ben hockey]

#14916 is a duplicate of this ticket.

[Colin Snover]

Please backport to 1.7 branch.

[Rawld Gill]

In [28399]:

backported fix for #14540; fixes #14540; !strict