Opened 8 years ago

Closed 8 years ago

#14524 closed defect (fixed)

"Open" not handled anymore in CssStateMixin

Reported by: alan Owned by: bill
Priority: high Milestone: 1.8
Component: Dijit Version: 1.7.0
Keywords: cssstatemixin, css, popup Cc:
Blocked By: Blocking:

Description (last modified by bill)

Dojo 1.6+ doesn't handle the "open" case anymore in CssStateMixin, so buttons with dropdowns open can't be styled, since there's no "dijitDropDownButtonOpened" class applied.

Mailing list reference: ​http://dojo-toolkit.33424.n3.nabble.com/1-7-What-happened-to-the-quot-opened-quot-class-for-dijit-dropdown-openers-td3564901.html

Change History (2)

comment:1 Changed 8 years ago by bill

Description: modified (diff)
Milestone: tbd → 1.8
Owner: set to bill
Status: new → assigned

Actually, _CssStateMixin never handled open, but now it's become more important in order to bring back the dijitDropDownButtonOpened class on DropDownButton.domNode.

_HasDropDown (and descendants, like DropDownButton) are setting this._opened, so can trigger off of that. In the future may want to refactor TitlePane, AccordionContainer children, etc. to leverage this mechanism too.

comment:2 Changed 8 years ago by bill

Resolution: → fixed
Status: assigned → closed

In [27461]:

Add back dijitDropDownButtonOpened class that used to be written before the conversion to use _HasDropDown, fixes #14524, refs #9356 !strict.

Note: See TracTickets for help on using tickets.