Opened 7 years ago

Closed 6 years ago

#14508 closed task (fixed)

PopupMenuItem: handle opening drop down

Reported by: bill Owned by: bill
Priority: low Milestone: 1.9
Component: Dijit Version: 1.7.1
Keywords: Cc:
Blocked By: Blocking:

Description (last modified by bill)

Move code to open submenus from _MenuBase into PopupMenuItem, removing the dependency from _MenuBase --> dijit/popup.

Also, make PopupMenuItem extend _HasDropDown rather than calling dijit/popup directly.

Continues on the refactoring from #12816.

Change History (3)

comment:1 Changed 7 years ago by bill

Description: modified (diff)

comment:2 Changed 6 years ago by bill

Milestone: future → 1.9
Owner: set to bill
Priority: high → low
Status: new → assigned
Summary: PopupMenuItem: extend _HasDropDown → PopupMenuItem: handle opening drop down

Given the complexities of menus, like how hovering MenuBar choice "B" will automatically close the drop down for MenuBar choice "A", it's probably not realistic for PopupMenuItem to extend _HasDropDown. Still, the dijit/popup dependency could be moved from _MenuBase to PopupMenuItem. _MenuBase can still open and close the popups, but indirectly, via an API exposed through PopupMenuItem.

I'm working on Menu now so I'll likely do this for 1.9.

comment:3 Changed 6 years ago by bill

Resolution: → fixed
Status: assigned → closed

In [30894]:

Move call to popup manager to PopupMenuItem, while leaving most of the logic in _MenuBase, at least for now. Fixes #14508 !strict.

Also remove delay to focus popup. No longer needed after [30893]. Refs #8742 !strict.

Note: See TracTickets for help on using tickets.