Opened 7 years ago

Closed 7 years ago

Last modified 7 years ago

#14506 closed defect (fixed)

Display errors in dojox.grid.enhanced.plugins.Pagination

Reported by: Michael670 Owned by: Evan
Priority: high Milestone: 1.7.2
Component: DojoX Grid Version: 1.7.0
Keywords: Cc:
Blocked By: Blocking:

Description

short story: in row 940 of Pagination.js (function: _onNew) this.grid.rowCount should be changed to this.grid.get('rowCount').

long story: if new items are added to the store of the grid the property rowCount returns a value that is not valid, what results in a wrong page size for the paginted grid and display errors. The correct value would be invalidated.rowCount. The getter for rowCount returns always the correct value.

thx.

Change History (4)

comment:1 Changed 7 years ago by Evan

Could you post a test case for this?

It's safe for that change, but I don't quite understand the issue you mentioned, I didn't see any logic related with invalidated.rowCount in DataGrid?.get() so isn't grid.get('rowCount') the same as grid.rowCount? Anything I missed?

comment:2 Changed 7 years ago by Michael670

Take a look at line 460 in _Grid.js:

_getRowCountAttr: function(){

return this.updating && this.invalidated && this.invalidated.rowCount != undefined ?

this.invalidated.rowCount : this.rowCount;

}

this method gets called if one use grid.get('rowCount') instead of grid.rowCount.

comment:3 Changed 7 years ago by Evan

Resolution: fixed
Status: newclosed

In [27451]:

Fixes #14506 by using grid.get('rowCount') instead of grid.rowCount, also applied to 1.7 branch, !strict

comment:4 Changed 7 years ago by Evan

Milestone: tbd1.7.2
Note: See TracTickets for help on using tickets.