[regression] connect to onpropertychange fails on IE9/quirks

[bill]

See attached test case, running on IE9. It will give an error in the console when it tries to

dojo.connect(dojo.body(), "onpropertychange", ..);

Worked in 1.6.

If the problem doesn't reproduce make sure in the developer console that browser mode and document mode are set to their defaults:

[bill]

browser and document mode screenshot (from IE developer console, F12 key)

[bill]

test case

[bill]

Note that the error has nothing to do with connecting to dojo.body(); it happens for any node.

[Kris Zyp]

In [27490]:

Reverse order of setting dispatcher variable and property to avoid error with IE's immediate firing of propertychange event when the event handler for that event is set, fixes #14503 !strict

[bill]

BTW, since this is a regression you might want to backport it to the 1.7 branch. OTOH it seems like an uncommon use case. TBH I'm surprised that anyone is connecting to onpropertychange, but apparently they are.

[bill]

Kris, this looks like a safe change, you don't mind if I backport it to 1.7 do you?

[Kris Zyp]

No, that's fine, go for it.

[bill]

Oh, actually turns out you already did it, in [27494], just didn't show up here.

[bill]

In [30344]:

add test for #14503 to 1.7 branch, refs #14503 !strict

[bill]

Note that this isn't an issue on 1.6 since dojo/on first appeared in 1.7.