Opened 8 years ago

Closed 8 years ago

Last modified 8 years ago

#14498 closed defect (fixed)

Mirroring problems for link dialog and image dialog

Reported by: ghada_selim Owned by: bill
Priority: high Milestone: 1.8
Component: Editor Version: 1.7.0
Keywords: Cc:
Blocked By: Blocking:

Description

Image Properties and Link Properties Dialogsis not mirrored when dir is specified on dijit.Editor widget level for the test dijit/tests/editor/test_Editor.html

Attachments (2)

dijit.editor.JPG​ (24.4 KB) - added by ghada_selim 8 years ago.
A snapshot for the problem
LinkDialog.js.patch​ (496 bytes) - added by bill 8 years ago.
patch from Ghada Selim (IBM, CCLA)

Download all attachments as: .zip

Change History (7)

Changed 8 years ago by ghada_selim

Attachment: dijit.editor.JPG​ added

A snapshot for the problem

comment:1 Changed 8 years ago by bill

Component: Dijit → Editor
Summary: Mirroring problems for dijit.Editor → Mirroring problems for link dialog and image dialog

I tried it on dojo 1.6 and dojo 1.7 on chrome and it worked fine. Worked on IE8 too. This is from running dijit/tests/editor/test_Editor.html?dir=rtl. What was your exact scenario to reproduce this?

comment:2 Changed 8 years ago by bill

Oh, this ticket description leaves out critical info from the original ticket: Image Properties and Link Properties Dialogsis not mirrored when dir is specified on dijit.Editor widget level for the test dijit/tests/editor/test_Editor.html.

Changed 8 years ago by bill

Attachment: LinkDialog.js.patch​ added

patch from Ghada Selim (IBM, CCLA)

comment:3 Changed 8 years ago by bill

Milestone: tbd → 1.8
Owner: set to bill
Status: new → assigned

comment:4 Changed 8 years ago by bill

Resolution: → fixed
Status: assigned → closed

In [27453]:

Pass editor's dir down to TooltipDialog, fixes #14498 !strict

comment:5 Changed 8 years ago by bill

In [27458]:

add test case for dir=rtl editor, refs #14498

Note: See TracTickets for help on using tickets.