Opened 7 years ago

Last modified 3 years ago

#14481 assigned defect

dojo.fx.wipeOut onEnd race condition due to connect()

Reported by: Karl Tiedt Owned by: dylan
Priority: high Milestone: 1.15
Component: fx Version: 1.7.1
Keywords: dojo.fx.wipeOut dojo.fx.wipeIn setTimeout race Cc:
Blocked By: Blocking:

Description

http://bugs.dojotoolkit.org/browser/dojo/dojo/trunk/fx.js#L371

If you look at that line of code you will see the wipeOut() connects to the anim.onEnd to do final styles on the node... if you are doing a wipeOut -> <do some dom manipulations> -> wipeIn trigged off onEnd of the wipeOut you are forced to set a 0ms setTimeout or the styles from the connect will get set AFTER the wipeIn begins (as long as the arbitrary code in the middle doesnt take more than a cycle or so)

Interestingly enough, dojo.fx.chain() of the 2 anims works, but I lose the ability to run code between the transitions

Change History (6)

comment:1 Changed 7 years ago by Karl Tiedt

Note: I just looked as to how dojo.fx.chain works w/o failing here

the secret is to dojo.connect to the onEnd since connects fire in sequence -- this at least is a temporary work around while avoiding setTimeout's

Would a possible solution be to setup Animations with an _onEnd that handles the "required" end setup an animation needs and then fire onEnd from that? that way any defined onEnd argument will always fire last... followed by any connected onEnds...

Last edited 7 years ago by Karl Tiedt (previous) (diff)

comment:2 Changed 7 years ago by Rawld Gill

Resolution: fixed
Status: newclosed

In [27536]:

added feature to config headers for text plugin; fixes #14481

comment:3 Changed 7 years ago by Rawld Gill

Resolution: fixed
Status: closedreopened

[27536] was for #14482

comment:4 Changed 6 years ago by yzuo

I encountered this issue with the implementation of a slider. Are there any updates on this defect?

comment:5 Changed 3 years ago by dylan

Milestone: tbd1.12
Owner: changed from Bryan Forbes to dylan
Status: reopenedassigned

comment:6 Changed 3 years ago by dylan

Milestone: 1.131.15

Ticket planning... move current 1.13 tickets out to 1.15 to make it easier to move tickets into the 1.13 milestone.

Note: See TracTickets for help on using tickets.