Opened 8 years ago

Closed 8 years ago

Last modified 8 years ago

#14479 closed defect (duplicate)

EnhancedGrid and RangeError

Reported by: matej Owned by: Evan
Priority: high Milestone: 1.6.2
Component: DojoX Grid Version: 1.7.1
Keywords: EnhancedGrid, BorderContainer, ContentPane Cc:
Blocked By: Blocking:

Description (last modified by bill)

When I use EnhancedGrid inside BorderContainer and ContentPane debugger gets a stack overflow.

Error messages: 

RangeError: Maximum call stack size exceeded
RangeError  Deferred.js:216

Attachments (3)

file3.htm​ (1007 bytes) - added by matej 8 years ago.
re.html​ (1.1 KB) - added by bill 8 years ago.
fixed the test case to run
re_evan.html​ (1.1 KB) - added by Evan 8 years ago.
Adding a newer version - working well with the only change of referring from correct EDG css - <LINK href="dojox/grid/enhanced/resources/tundra/EnhancedGrid.css" rel="stylesheet">

Download all attachments as: .zip

Change History (13)

Changed 8 years ago by matej

Attachment: file3.htm​ added

comment:1 Changed 8 years ago by bill

Component: Dijit → DojoX Grid
Description: modified (diff)
Owner: set to Evan
Priority: highest → normal

Matej - Again, your test file is referencing a sample.js that doesn't exist. Please attach self contained test files to future tickets.

Evan - this has infinite recursion in the Grid code.

Changed 8 years ago by bill

Attachment: re.html​ added

fixed the test case to run

comment:2 Changed 8 years ago by myersjj

I have the same issue - this is a block for me with 1.7.1

comment:3 Changed 8 years ago by Evan

So this was caused by an inappropriate usage - Grid needs an explicit width/height otherwise it can't layout itself correctly.

Also there seems to be a missed width on the left content pane in re.html. Adding a refined version of re.html that works well for me now

comment:4 Changed 8 years ago by Evan

Resolution: → invalid
Status: new → closed

Closing since it's due to an inappropriate usage/test case.

comment:5 Changed 8 years ago by myersjj

Well my code worked just fine on 1.6.1.

At the very least this is a regression and should not cause infinite loop.

comment:6 Changed 8 years ago by bill

Evan - why do you need to explicitly set a size on the grid? It should be getting it's size set from the parent ContentPane, which is getting it's size set from the parent BorderContainer.

(It looks like the test case is missing setting padding:0, margin: 0 on body and html, not sure if that's related to anything.)

comment:7 in reply to:  6 Changed 8 years ago by Evan

Milestone: 1.8 → 1.6.2
Resolution: invalid → duplicate

Thanks Bill/myersjj,

I finally figured it out, this is a defect and is duplicate with #14504:

"It's actually a regression caused by [27395], already fixed with [27440](which has been applied to 1.6/1.7/trunk)"

Last edited 8 years ago by Evan (previous) (diff)

Changed 8 years ago by Evan

Attachment: re_evan.html​ added

Adding a newer version - working well with the only change of referring from correct EDG css - <LINK href="dojox/grid/enhanced/resources/tundra/EnhancedGrid.css" rel="stylesheet">

comment:8 Changed 8 years ago by myersjj

I can confirm that copying the updated Pagination.js file (from #27440) into my 1.7.1 installation resolved the problem. Thanks!

comment:9 in reply to:  6 Changed 8 years ago by Evan

Replying to bill:

Evan - why do you need to explicitly set a size on the grid? It should be getting it's size set from the parent ContentPane, which is getting it's size set from the parent BorderContainer.

Yes, Bill,

No need to set grid size in this case, just uploaded a ​newer version

comment:10 in reply to:  8 Changed 8 years ago by Evan

Replying to myersjj:

I can confirm that copying the updated Pagination.js file (from #27440) into my 1.7.1 installation resolved the problem. Thanks!

No problem, great it's working for you now.

Note: See TracTickets for help on using tickets.