Opened 8 years ago

Closed 6 years ago

#14457 closed defect (patchwelcome)

DataGrid with no scroll rows and autoHeight/rowHeight alignment problems, and column resize problems.

Reported by: ejellard Owned by: Evan
Priority: high Milestone: tbd
Component: DojoX Grid Version: 1.7.0
Keywords: Cc: dojo@…
Blocked By: Blocking:

Description

If you set a rowHeight or autoHeight != true, and have some locked columns, the rows do not align on the left (locked rows) and the right (horizontally scrollable).

This can be seen at http://staging.onlinescoutmanager.co.uk/grid.html

All browsers are problematic with the first grid on the page above, and IE is also problematic on the second grid.

There is also a problem resizing the columns in all browsers - resizing one non-locked column will sometimes resize another column, sometimes resize it correctly, and sometimes it doesn't resize anything!

Change History (7)

comment:1 Changed 8 years ago by ejellard

Hi,

1.7.1 appears to have fixed all of the problems, with the exception of specifying both a rowHeight and autoHeight values, when coupled with locked/noscroll columns. Personally I don't need rowHeight and autoHeight specified, so 1.7.1 has fixed my issues, but I guess it's still a bug!

The URL above is now dojo 1.7.1.

Thanks, Ed

Version 0, edited 8 years ago by ejellard (next)

comment:2 Changed 8 years ago by bill

Component: GeneralDojoX Grid
Owner: set to Evan

comment:3 Changed 8 years ago by ejellard

Hi,

The test page here demonstrates the resize problem - http://archive.dojotoolkit.org/nightly/checkout/dojox/grid/tests/test_sizing_ResizeHandle.html

It is still random - sometimes it works, sometimes it doesn't!!

Thanks, Ed

comment:4 Changed 7 years ago by ejellard

After a bit more experimentation with the nightly build URL above, it is a bit more repeatable:

  1. When it goes wrong, it resizes the column that's not adjacent, but the next one along (i.e. resizing Col 3 actually resizes Col 5) (possibly as there are two locked columns - not sure...)
  2. It seems to go wrong when the header cell that is highlighted is not the one that is being resized - so resizing Col 3 goes wrong if Col 4 somehow gets highlighted even though you are resizing Col 3, resulting in Col 5 being resized to whatever size you wanted Col 3 to be. After looking in the code, the cellIndex appears to be wrong.

Hope this makes sense.

Thanks, Ed

comment:5 Changed 7 years ago by ejellard

I can confirm point 1 above - if you have two locked columns, it sometimes resizes the column 2 along from the one you wanted. If you have three locked columns, it sometimes resizes the one three along from it..

I have disabled column resizing on my site and am now using 1.7.1 happily, but it'd obviously be great to be able to enable resizing. I've tried looking through the dojo source code, but it's a little over my head!!

Cheers, Ed

comment:6 Changed 6 years ago by bill

DojoX Grid and EnhancedGrid are deprecated in favor of dgrid and gridx.

You should upgrade your code to use one of those two grids.

We will consider patches to the old DojoX Grid code though.

comment:7 Changed 6 years ago by bill

Resolution: patchwelcome
Status: newclosed
Note: See TracTickets for help on using tickets.