error returning dojo.Deferred instead of doh.Deferred from DOH test

[mm]

Runner crashes and prevents other methods from executing/

Reason is line:

1328 doh._testFinished(groupName, fixture, ret.results[0]);

in runner.js and ret.results being undefined

See attached testcase and screenshot from FF+FB

[mm]

one quick comment: shall we use doh.Deferred or Deferred ?

sample ​http://livedocs.dojotoolkit.org/util/doh#simple-tests-no-setup-standalone-asynchronous-test states doh.Deferred, however it has no deferred.reject method as specified in the sample

[bill]

works using doh.Deferred, run as util/doh/runner.html?testModule=test.simplifiedWorks&registerModulePath=test,/trunk/runTests.html/..

[bill]

failure using dojo/_base/Deferred, run as ​http://localhost/trunk/util/doh/runner.html?testModule=test.simplified&registerModulePath=test,/trunk/runTests.html/..

[bill]

In the past you needed to return doh.Deferred(). In 1.7 (and 1.6.1 and 1.5.2) you should be able to return dojo.Deferred(), see #12463. However, looks like you found a bug with that. The workaround is to keep using doh.Deferred.

As you mentioned, the documentation is inaccurate in that doh.Deferred still has the old names for methods: callback() and errback(), rather than resolve() and reject(). I'll update that.

[mm]

or alias the methods in doh.Deffered as well.

[bill]

Updated ​http://livedocs.dojotoolkit.org/util/doh to not mention resolve() or reject() in ​https://github.com/dojo/docs/commit/653ce4a1de48dce045385aacb602558c2061b3a5

[bill]

In [27362]:

Fix internal DOH exception when returning dojo.Deferred from a test where the Deferred threw, fixes #14439, refs #12463 !strict.

[mm]

does it mean we shall try to use Deferred again instead of doh.Deffered for asnyc test results ?

[bill]

Well, you can use a dojo.Deferred if it's more convenient. Most of the time doh.Deferred makes sense because it has convenient getTestCallback() and getTestErrback() methods.