FilteringSelect: required=true considers value="" valid

[jond]

This is my first bug report, I apologize if its improper. Im using svn trunk.

So basically, If i use required:true the FilteringSelect? does not consider value="" as an invalid option. Example.

<select id="foo" data-dojo-type="dijit.form.FilteringSelect" data-dojo-props="required:true">
<option value="">-Please Select-</option>
<option value="valid">valid option</option>
</div>

Examination of the isValid() function reveals.

return this.item || (!this.required && this.get('displayedValue') == ""); // #5974

this.item is an object --> Object { name="-Please Select-", id="", value=""}

Since it is likely that this.item will always be an object of that nature... wouldn't this function always return true?

Is this correct? Or am I suppose to override isValid()?

[bill]

Huh, isn't that the whole point of required:true flag?

Notes on bug system:

• fill in proper component
• try to make summary descriptive
• use triple curly braces to bracket code examples
• attach test case using the attach file button

Thanks.

[jond]

My title is incorrect. it should be. FilteringSelect?: required=true considers value="" valid.

Thank you for the formatting help.

[Douglas Hays]

The FilteringSelect? has a valid value="" with displayed value="Please Select". Since it is user selectable, then it's valid. You probably meant:

<select id="bar" data-dojo-type="dijit.form.FilteringSelect" data-dojo-props="required:true" placeHolder="Please Select" value="">
<option value="valid">valid option</option>
<option value="valid2">valid option 2</option>
</select>

If this isn't what you meant, then you will need a custom isValid method.