Opened 8 years ago

Closed 7 years ago

Last modified 7 years ago

#14396 closed enhancement (fixed)

grid accessibility: need to be able to add a summary attribute to a DataGrid

Reported by: Becky Gibson Owned by: Evan
Priority: low Milestone: 1.8
Component: Accessibility Version: 1.7.0
Keywords: Cc: mikeb
Blocked By: Blocking:

Description

The user should be able to add a summary attribute onto a DataGrid? in order to meet the WGAG 2.0 1.3.1 success criterion (http://www.w3.org/TR/2008/REC-WCAG20-20081211/#content-structure-separation-programmatic).

Currently if you add a summary attribute into the markup for a DataGrid?, the attribute is not part of the generated grid.

The enhanced datagrid needs this capability as well.

Attachments (1)

14396.patch (2.5 KB) - added by Evan 7 years ago.
Proposed fix patch

Download all attachments as: .zip

Change History (17)

comment:1 Changed 8 years ago by bill

Milestone: 1.7.11.7.2

These didn't make it into the 1.7.1RC, so bumping them to 1.7.2 (as stated in the email I sent yesterday).

comment:2 Changed 8 years ago by Colin Snover

Priority: highblocker

Bulk update of open ticket priorities.

comment:3 Changed 8 years ago by Colin Snover

Priority: blockerlow

Reducing priority.

comment:4 Changed 8 years ago by Colin Snover

Milestone: 1.7.21.7.3

1.7.2 RC released, bumping milestone on remaining tickets.

comment:5 Changed 7 years ago by Colin Snover

Milestone: 1.7.31.8
Type: defectenhancement

This is an enhancement, so moving to a major release milestone.

comment:6 Changed 7 years ago by Douglas Hays

Cc: mikeb added; evan removed
Owner: changed from Becky Gibson to Evan
Status: newassigned

comment:7 Changed 7 years ago by Colin Snover

Milestone: 1.82.0

1.8 is frozen. Move all enhancements to next release. If you need an exemption from the freeze for this ticket, contact me immediately.

comment:8 Changed 7 years ago by bill

dijit/_PaletteMixin.js has a summary too, you can probably do something similar:

// summary: String
//              Localized summary for the palette table
summary: '',
_setSummaryAttr: "paletteTableNode",

comment:9 in reply to:  8 ; Changed 7 years ago by Evan

Replying to bill:

dijit/_PaletteMixin.js has a summary too, you can probably do something similar:

// summary: String
//              Localized summary for the palette table
summary: '',
_setSummaryAttr: "paletteTableNode",

Thanks Bill,

As Grid is not using _CSSStateMixin at this moment, that might involve certain changes. So I just go ahead with the most simple way(with the patch).

comment:10 in reply to:  7 Changed 7 years ago by Evan

Replying to csnover:

1.8 is frozen. Move all enhancements to next release. If you need an exemption from the freeze for this ticket, contact me immediately.

Hi Colin,

I think this is more like a defect to add a missed ARIA attr, the fix is trivial. Please let me know if it's OK to go ahead getting this into 1.8?

Thanks!

Changed 7 years ago by Evan

Attachment: 14396.patch added

Proposed fix patch

comment:11 in reply to:  9 Changed 7 years ago by Evan

Replying to Evan:

Thanks Bill,

As Grid is not using _CSSStateMixin at this moment, that might involve certain changes. So I just go ahead with the most simple way(with the patch).

Sorry, please just ignore this, nothing related with _CSSStateMixin, it's working nicely with the updated patch.

comment:12 Changed 7 years ago by Colin Snover

I don’t have a problem with this being landed except that I would r- the patch that was uploaded for providing a bad default value on the summary and for seemingly not actually providing updated unit tests to check that setting this property actually works.

comment:13 Changed 7 years ago by Evan

Resolution: fixed
Status: assignedclosed

In [28908]:

Fixes #14396 !strict, summary attr working well with to all grid types

comment:14 Changed 7 years ago by Evan

Milestone: 2.01.8

Also updated in the grid doc

comment:15 Changed 7 years ago by Evan

In [29626]:

Refs #14396 also adding role="presentation" to FilterBar? template, backported to 1.8.x, 1.7.x branch

comment:16 Changed 7 years ago by Evan

In [29746]:

Refs #14396 !strict, using focusNode so that JAWS can read the filter input field

Note: See TracTickets for help on using tickets.