Opened 7 years ago

Closed 3 years ago

#14376 closed defect (patchwelcome)

regression in dojox.widget.MultiSelectCalendar

Reported by: Jean-Rubin Leonard Owned by: Adam Peller
Priority: high Milestone: 1.13
Component: DojoX Widgets Version: 1.7.0
Keywords: Cc:
Blocked By: Blocking:

Description (last modified by Adam Peller)

the dojox.widget.MultiSelectCalendar is a fork of dijit.Calendar that gives the calendar the functionality to select several dates. Due to changes introduced in r25901, the widget broke. In the meantime, dijit.Calendar went through some significant changes. It would be too time consuming to apply the same changes to dojox.widget.MultiSelectCalendar. Reforking dijit.Calendar and reimplementing the functional changes is an equally long and tedious tasks and the fact that the widget broke a bare two months after it went live show the danger of forking the way we did it as an endless game of cat and mouse.

At the current r27185, the widget broke with an error message whenever we click on a calendar date to select. The error message is "Date object is undefined". After some tracing and logging, it appears the _setCurrentFocusAttr method modifies the value of the date its supposed toset the current focus to. When I console.log date's value AFTER it return from the setter it's undefined. I couldn't figure out an explanation nor a reason for the behavior.

I also get deprecated messages about getAttributeNodeNS() but cannot find it in my source.

Change History (3)

comment:1 Changed 7 years ago by Adam Peller

Description: modified (diff)
Milestone: 1.7.1tbd
Owner: changed from dante to Adam Peller

comment:2 Changed 7 years ago by bill

Also broken due to [28655], fixed in dijit in [28684].

comment:3 Changed 3 years ago by dylan

Milestone: tbd1.12
Resolution: patchwelcome
Status: newclosed

Given that no one has shown interest in creating a patch in the past 4+ years, I'm closing this as patchwelcome.

Note: See TracTickets for help on using tickets.