'invalid label' error when loading i18n resource file

[dholden]

Loading a JSON resource file, that requires localization and that does not have parenthesis [()] around the JSON object, causes an 'invalid label' error in the browser (FF 8.0).

Steps to reproduce: Call dojo.requireLocalization("../<resource location>", "strings") where strings.js is: {

"STRING_1" : "My String"

}

The "evalBundle" function, in dojo/dojo/i18n.js, calls "eval(bundle)" for each resource being loaded. Changing "eval(bundle)" to "eval('(' + bundle + ')')" would solve this problem.

[dholden]

Suggested Patch to i18n.js

[Adam Peller]

I believe the first argument to requireLocalization should be a package name, not a filepath (i.e. no "../") But it does sound like the eval should supply the parens.

[Adam Peller]

consider for 1.7

[bill]

These didn't make it into the 1.7.1RC, so bumping them to 1.7.2 (as stated in the email I sent yesterday).

[dholden]

depsScan.js has the same issue in evalNlsResource() - line 409:

var result= eval(text);

--should become--

var result= eval("("+text+")");

[Rawld Gill]

In [27774]:

improved sniffing of i18n bundles in backcompat mode; fixed test; refs #14375; fixes #14222; refs #14226; !strict

[Rawld Gill]

In [27795]:

backport [27774], fixes #14375; !strict