Changes between Initial Version and Version 1 of Ticket #14341, comment 3


Ignore:
Timestamp:
Dec 1, 2011, 8:58:23 AM (8 years ago)
Author:
cjolif
Comment:

Legend:

Unmodified
Added
Removed
Modified
  • Ticket #14341, comment 3

    initial v1  
    55The problem appears when !CheckBox is build with passing value:"" in the ctor.
    66
    7 Then after the mixin of ctor properties, in !_CheckBoxMinx.postMixInProperties() when !CheckBox.value is "" it is transform back to "on" (the default value). As we now use this.params!["value"] and not anymore this!["value"] to actually set the value in applyAttributes the values goes back to "" instead of the previously expected "on". And the test finally fail because it obviously expects "on" to be there.
     7Then after the mixin of ctor properties, in _CheckBoxMinx.postMixInProperties() when !CheckBox.value is "" it is transform back to "on" (the default value). As we now use this.params!["value"] and not anymore this!["value"] to actually set the value in applyAttributes the values goes back to "" instead of the previously expected "on". And the test finally fail because it obviously expects "on" to be there.
    88
    99I think the actual problem does not come from the code modification but from the fact !CheckBox behavior is not consistent between what happens in ctor (where postMixInProperties override "" to "on") and what happens in the setter where the same job is not done (i.e. "" is kept and not transformed to "on").