#14324 closed task (fixed)
remove editor reference to dijit global
Reported by: | bill | Owned by: | bill |
---|---|---|---|
Priority: | high | Milestone: | 1.7.5 |
Component: | Editor | Version: | 1.7.0 |
Keywords: | Cc: | Douglas Hays, ben hockey | |
Blocked By: | Blocking: |
Description
The editor references the dijit global during initialization as a way to set the <iframe> initial contents:
var iframeSrcRef = 'parent.' + dijit._scopeName + '.byId("'+this.id+'")._iframeSrc'; var s = 'javascript:(function(){try{return ' + iframeSrcRef + '}catch(e){document.open();document.domain="' + document.domain + '";document.write(' + iframeSrcRef + ');document.close();}})()';
This indirection of making src point at a variable, rather then just being a string literal, was done due to a limitation of the src attribute length in an old browser. Need to check what that browser was and if we still support it or not.
The current design is stopping dijit from working without globals.
Change History (4)
comment:1 Changed 9 years ago by
Summary: | editor reference to dijit global → remove editor reference to dijit global |
---|---|
Type: | defect → task |
comment:4 Changed 8 years ago by
Milestone: | 1.8 → 1.7.5 |
---|
Note: See
TracTickets for help on using
tickets.
My tests (all on Windows) with inlined src:
It looks like it's no longer necessary to use that parent.dijit._iframeSrc indirection.