Opened 10 years ago

Closed 10 years ago

Last modified 10 years ago

#14318 closed defect (fixed)

[regression] dojox.fx no longer aliases various base/core api's

Reported by: dante Owned by: Chris Mitchell
Priority: high Milestone: 1.8
Component: Dojox Version: 1.7.0
Keywords: Cc: Bryan Forbes, cjolif
Blocked By: Blocking:

Description

Prior to [26273] dojox/fx/_base.js would actually create aliases on the dojox.fx object, normalizing and adding a few _private animations (_fade). This was commented out as part of the AMD refactor.

Attachments (1)

14318.patch (2.0 KB) - added by cjolif 10 years ago.
potential patch for the issue

Download all attachments as: .zip

Change History (12)

comment:1 Changed 10 years ago by bill

Component: GeneralDojox
Owner: set to Adam Peller

This is OK to wait until 1.8? It's marked as a regression and priority=high, but milestone=1.8.

comment:2 Changed 10 years ago by Adam Peller

Cc: Bryan Forbes Chris Mitchell added
Milestone: 1.81.7.1
Owner: changed from Adam Peller to dante

was anything impacted which was public? moving to 1.7.1 for consideration

comment:3 Changed 10 years ago by bill

Milestone: 1.7.11.7.2

These didn't make it into the 1.7.1RC, so bumping them to 1.7.2 (as stated in the email I sent yesterday).

comment:4 Changed 10 years ago by Colin Snover

Priority: highblocker

Bulk update of open ticket priorities.

comment:5 Changed 10 years ago by Colin Snover

Priority: blockerhigh

Reducing priority.

comment:6 Changed 10 years ago by Colin Snover

Milestone: 1.7.21.7.3

1.7.2 RC released, bumping milestone on remaining tickets.

comment:7 Changed 10 years ago by Colin Snover

Keywords: needsreview added
Milestone: 1.7.31.8

Not sure what this is for. Can someone that understand this problem look at the output of the new doc parser and confirm it is fixed?

comment:8 Changed 10 years ago by bill

#15457 is a duplicate of this ticket.

comment:9 Changed 10 years ago by bill

Cc: cjolif added; Chris Mitchell removed
Keywords: needsreview removed
Owner: changed from dante to Chris Mitchell
Status: newassigned

It's not fixed, and it's not related to the doc parser. It's an actual issue with the code, where some previously defined symbols, such as dojox.fx.fadeTo(), were removed.

Changed 10 years ago by cjolif

Attachment: 14318.patch added

potential patch for the issue

comment:10 Changed 10 years ago by cjolif

Resolution: fixed
Status: assignedclosed

patch applied, let me know if there are still an issue.

comment:11 Changed 10 years ago by cjolif

see [28729]

Note: See TracTickets for help on using tickets.