Opened 10 years ago

Last modified 10 years ago

#14291 closed defect

dojox.mobile.themeMap base theme in themeMap — at Initial Version

Reported by: Bill Reed Owned by: ykami
Priority: high Milestone: 1.8
Component: DojoX Mobile Version: 1.7.0
Keywords: Cc: Adam Peller
Blocked By: Blocking:

Description

I am defining a custom dojox.mobile.themeMap=Android",null,["../themes/custom/custom.css?,["BlackBerry?",null,themes/custom/custom.css?],["iPad",null,themes/custom/custom.css?],["iPhone",null,themes/custom/custom.css?],[".*",null,themes/custom/custom.css?]]; });

I do not want a base theme added to the head but dojox.mobile.deviceTheme expects a base, deviceTheme adds a link to <link href="../../../dojox/mobile/themes/null/null.css" type="text/css" rel="stylesheet">

it would be nice if loadDeviceTheme would check the base theme for null before adding it to the head to prevent a 404 error

I have attached a html file with the test case and a example dojox.mobile.deviceTheme.js that has been patched

Change History (2)

Changed 10 years ago by Bill Reed

Attachment: my_test_iPhone-Heading.html added

html test case

Changed 10 years ago by Bill Reed

Attachment: deviceTheme.js added

proposed fix

Note: See TracTickets for help on using tickets.