Opened 8 years ago

Closed 7 years ago

#14284 closed task (fixed)

use dojo/domReady! in dojo/uacss.js and dojo/hccss.js

Reported by: bill Owned by: bill
Priority: high Milestone: 1.8.1
Component: Core Version: 1.7.0
Keywords: Cc: Kenneth G. Franqueiro, Rawld Gill
Blocked By: Blocking:

Description

Use dojo/domReady! rather than dojo/ready in dojo/uacss.js and dijit/hccss.js, so that more client code can use dojo/domReady! rather than dojo/ready.

Unfortunately this can't be done until 2.0 because it will break sync mode loading. In particular dijit/tests/_Templated-widgetsInTemplate1.x fails (possibly among other tests), tested at [27069]. The loader doesn't throw an error but the dojo.ready() fires before the dojo.require("dijit._Widget") has resolved... thus leading to problems defining Test3Widget.

See attached patch.

Attachments (1)

domReadyTest.patch (2.3 KB) - added by bill 8 years ago.
changes dojo/ready usage to dojo/domReady!

Download all attachments as: .zip

Change History (3)

Changed 8 years ago by bill

Attachment: domReadyTest.patch added

changes dojo/ready usage to dojo/domReady!

comment:1 Changed 7 years ago by bill

Component: GeneralCore
Owner: set to bill
Status: newassigned
Summary: use dojo/domReady! in dojo/uacss.js and dijit/hccss.jsuse dojo/domReady! in dojo/uacss.js and dojo/hccss.js

hccss was moved to dojo/

comment:2 Changed 7 years ago by bill

Milestone: 2.01.8.1
Resolution: fixed
Status: assignedclosed

Actually, this was handled in [29507], and see also [29511]. Those modules are using domReady() as a function, but client code can still use dom/domReady! as a plugin.

Last edited 7 years ago by bill (previous) (diff)
Note: See TracTickets for help on using tickets.