Opened 11 years ago
Closed 10 years ago
#14282 closed defect (fixed)
Avatar.update() does not respect Source.generateText property
Reported by: | Simon Speich | Owned by: | bill |
---|---|---|---|
Priority: | high | Milestone: | 1.8 |
Component: | DnD | Version: | 1.7.0 |
Keywords: | Cc: | ||
Blocked By: | Blocking: |
Description
Each dnd source has a generateText property which is set to true by default in Source.js line 100. When constructing the Avatar this property is checked before calling this._generateText() on line 51 in Avatar.js, but not when updating the avatar on line 110.
Quick fix in Avatar.js line 110:
node.innerHTML = this._generateText();
should be:
node.innerHTML = this.manager.source.generateText ? this._generateText() : ""
Note: If this get's fixed then dijit.tree.dndSource.js has to be fixed too, since it doesn't set this property and would not display the text anymore when dragging. Should I open a separate bug for that?
Change History (6)
comment:1 follow-up: 2 Changed 11 years ago by
comment:2 Changed 11 years ago by
Replying to bill:
So the bug is that when a dojo.dnd.Source sets generateText: false, it still generates the text?
correct (as soon as update is called)
(I'm unclear what the text is, apparently just for example a (3) to indicate that three items are being dragged?)
correct, but I customized it to display 'Copy' or 'Move'. So it can be more than that.
Probably not worth opening a separate ticket for Tree, just need to add a
generateText: trueinto dijit/tree/dndSource.html, right?
yep (in dijit/tree/dndSource.js)
comment:3 Changed 11 years ago by
Milestone: | → tbd |
---|
comment:4 Changed 10 years ago by
Component: | DnD → Dijit |
---|---|
Owner: | changed from Eugene Lazutkin to bill |
Status: | new → assigned |
It looks to me (indirectly) that this is a Dijit ticket.
comment:5 Changed 10 years ago by
Component: | Dijit → DnD |
---|---|
Milestone: | tbd → 1.8 |
it's more of a DnD bug but I'll check in the fix.
So the bug is that when a dojo.dnd.Source sets generateText: false, it still generates the text? (I'm unclear what the text is, apparently just for example a (3) to indicate that three items are being dragged?)
Probably not worth opening a separate ticket for Tree, just need to add a
into dijit/tree/dndSource.html, right?