Opened 11 years ago

Closed 11 years ago

Last modified 11 years ago

#14280 closed defect (wontfix)

dojo.xd.js does not pick up data-dojo-config

Reported by: Adam Peller Owned by: Rawld Gill
Priority: high Milestone: 1.7.1
Component: BuildSystem Version: 1.6.1
Keywords: Cc: Kenneth G. Franqueiro, phiggins, snover
Blocked By: Blocking:


comments from rawld

The issue Ken points out below is true: xdomain dojo, if renamed dojo.xd.js, won't pick up config off of data-dojo-config. I don't think we should publish dojo.xd.js any more. It's just dojo.js renamed...why add this complexity. Remember, this is not really a backcompat issue: if a user wants to upgrade to 1.7 from 1.6 they will have to change the URL anyway; why not tell them to remove ".xd" while they are at it. Perpetuating the idea that xdomain is different seems like a bad idea.

Logging this ticket for consideration. phiggins argues that we should continue supporting dojo.xd.js through 2.0, since people already using CDN will undoubtably just try to update the release. It's also unclear whether there's an easy way for Google to list our project with different url schemes for different versions without splitting it off and making it look like a new toolkit.

Change History (5)

comment:1 Changed 11 years ago by Adam Peller

Owner: changed from rawld to Rawld Gill

comment:2 Changed 11 years ago by Kenneth G. Franqueiro

Upon further consideration, we (myself, Pete, Adam, Dylan) have come to an agreement that holding on to the .xd.js "artifact" for "back-compat" is probably not in our best interests, and we should simply promote the use of dojo.js everywhere going forward.

That said, The last sentence in Rawld's description is the one thing of particular concern to me - we need to ensure that all versions of Dojo continue to operate from (and are properly documented on) Google's CDN.

comment:3 Changed 11 years ago by Adam Peller

In [27112]:

revert r26957. No longer supporting dojo.xd.js Refs #14209, #14280

comment:4 Changed 11 years ago by bill

Resolution: wontfix
Status: newclosed

comment:5 Changed 11 years ago by Kenneth G. Franqueiro

In [27319]:

Apply r27112 (from 1.7 branch) to trunk as well to no longer copy dojo.js -> dojo.xd.js; refs #14209, #14280

Note: See TracTickets for help on using tickets.