Opened 7 years ago

Last modified 3 years ago

#14279 new task

[meta] convert test files to AMD

Reported by: bill Owned by: dylan
Priority: high Milestone: 2.0
Component: Testing Version: 1.7.0
Keywords: Cc:
Blocked By: Blocking:

Description


Change History (43)

comment:1 Changed 7 years ago by bill

In [27053]:

remove commented out references to helper.js from dojox.mobile, refs #14279

comment:2 Changed 7 years ago by bill

In [27059]:

Convert helper.js to AMD baseless, except for onFocus() function which is problematic because in needs to work with DOH robot and monitor focus changes in the iframe. Refs #14279 !strict.

comment:3 Changed 7 years ago by bill

In [27160]:

update to AMD, refs #14279

comment:4 Changed 7 years ago by bill

In [28024]:

dojo.require() --> require(), refs #14279

comment:5 Changed 7 years ago by bill

Blocked By: 14929 added

comment:6 Changed 7 years ago by bill

Component: DijitGeneral
Milestone: 1.82.0
Summary: convert dijit test files to AMD[meta] convert test files to AMD

There are a lot of test files in dojo core that still need to be converted, so expanding this ticket.

comment:7 Changed 7 years ago by bill

In [28496]:

Require "doh/main" rather than "doh", and "dojo/main" rather than "dojo", per our convention to list modules explicitly rather than using package mapping (although still using a mapping from doh --> util/doh).

The dojo test files are inconsistent in their use absolute paths or relative paths to pull in dojo source modules. I didn't fix that.

Also didn't adjust the files in dojo/_base/loader since they may be trying to test package mapping, and didn't fix a bunch of test files that are still in the old dojo.require() format.

Refs #14279 !strict.

comment:8 Changed 7 years ago by bill

In [28893]:

Use full path to test modules, otherwise after [28496] it doesn't work, refs #14279 !strict.

comment:9 Changed 7 years ago by bill

In [28894]:

[28496] accidentally removed ObjectStore test, putting it back, refs #14279 !strict.

comment:10 Changed 6 years ago by bill

In [29056]:

convert test file to AMD, refs #14279

comment:11 Changed 6 years ago by bill

Blocked By: 14929 removed

Fixed #14929 a while ago.

comment:12 Changed 6 years ago by bill

In [29785]:

convert non-robot BorderContainer? test to AMD, refs #14279

comment:13 Changed 6 years ago by bill

In [30274]:

remove unused modules from dependency list, and upgrade to use new dojo/Deferred code, refs #14279 !strict

comment:14 Changed 6 years ago by bill

In [30358]:

convert core test files to AMD, skipping deprecated modules, refs #14279 !strict

comment:15 Changed 6 years ago by bill

In [30360]:

fix typos in AMD conversion, refs #14279 !strict

comment:16 Changed 6 years ago by bill

In [30366]:

remove dojo/main dependency from core tests (part 1), refs #14279 !strict

comment:17 Changed 6 years ago by bill

In [30370]:

remove dojo/main dependency from non-deprecated dojo/tests/_base test files, refs #14279 !strict

comment:18 Changed 6 years ago by bill

In [30374]:

Remove more dojo/main dependencies from core tests , refs #14279 !strict.

Also remove dojo/query/NodeList_identity test since it's apparently testing a backwards-compatibility feature of dojo/_base/NodeList (but not dojo/NodeList).

comment:19 Changed 6 years ago by bill

In [30376]:

a few more AMD conversions of test files, plus switch from dojoType to data-dojo-type, refs #14279 !strict.

comment:20 Changed 6 years ago by bill

In [30392]:

fix typo from [30374], refs #14279 !strict

comment:21 Changed 6 years ago by bill

In [30424]:

convert tests to AMD, refs #14279

comment:22 Changed 6 years ago by bill

In [30428]:

convert module.js test files to AMD, refs #14279

comment:23 Changed 6 years ago by bill

In [30494]:

remove stray dojo global reference, refs #14279

comment:24 Changed 6 years ago by bill

In [30513]:

update some dijit infrastructure tests to AMD, stop using dojo/ready, prefer _WidgetBase to _Widget except when testing deprecated functionality, etc., refs #14279

comment:25 Changed 6 years ago by bill

In [30527]:

update Dialog.html to AMD, refs #14279

comment:26 Changed 6 years ago by bill

In [30528]:

Fix error from [28024]: there's no such thing as window.location.href.test. Refs #14279.

comment:27 Changed 6 years ago by bill

In [30530]:

don't depend on deprecated dijit._curFocus variable from tree robot tests, refs #14279

comment:28 Changed 6 years ago by bill

In [30532]:

convert Select test to AMD, refs #14279

comment:29 Changed 6 years ago by bill

In [30541]:

convert layout tests to AMD, refs #14279

comment:30 Changed 6 years ago by bill

In [30542]:

fixup from layout test AMD conversion (getResponse.php change), refs #14279

comment:31 Changed 6 years ago by bill

In [30543]:

fix missing dependency on dojo/_base/declare, refs #14279 !strict

comment:32 Changed 6 years ago by bill

In [30676]:

convert Editor_mouse.html to AMD, and stop using internal editor command for selecting all the text, refs #14279

comment:33 Changed 6 years ago by bill

In [30802]:

Don't assume that the focus manager is loaded or dojo.subscribe is defined in the iframe. For AMD tests they may not be. Plus fixing a few references to the dojo global. Refs #14279 !strict.

comment:34 Changed 6 years ago by bill

In [30803]:

Add missing dependency, refs #14279 !strict.

comment:35 Changed 6 years ago by bill

In [30804]:

Access dijit/tests/helpers methods through AMD, refs #14279.

comment:36 Changed 6 years ago by bill

In [31108]:

convert Textarea test to AMD, refs #14279

comment:37 Changed 6 years ago by bill

In [31109]:

Convert (non-robot) Textarea test to AMD. This fixes a problem running the associated robot test on IE10, which was running all the tests before robot had finished initializing. Not sure why though. Refs #14279.

comment:38 Changed 6 years ago by bill

In [31429]:

convert Editor robot tests to AMD, refs #14279

comment:39 Changed 6 years ago by bill

In [31438]:

convert Tree robot tests to AMD, refs #14279

comment:40 Changed 4 years ago by Bill Keese <bill@…>

In 3d05fa371edf7829724421c6c05fbe39953c2580/dijit:

Error: Processor CommitTicketReference failed
Unsupported version control system "git": Can't find an appropriate component, maybe the corresponding plugin was not enabled? 

comment:41 Changed 4 years ago by Bill Keese <bill@…>

In d6e17c48ae34129655dc3f79e3c4ad2dca0c73b2/dijit:

Error: Processor CommitTicketReference failed
Unsupported version control system "git": Can't find an appropriate component, maybe the corresponding plugin was not enabled? 

comment:42 Changed 4 years ago by Bill Keese <bill@…>

In 956b95dec7affd8eca77d3788373e045853b4e46/dijit:

Error: Processor CommitTicketReference failed
Unsupported version control system "git": Can't find an appropriate component, maybe the corresponding plugin was not enabled? 

comment:43 Changed 3 years ago by dylan

Component: GeneralTesting
Owner: set to dylan
Note: See TracTickets for help on using tickets.