Opened 8 years ago

Closed 8 years ago

Last modified 8 years ago

#14272 closed defect (fixed)

html/ext-dojo/style.js: DOMAttr.hasAttr should be changed to DOMAttr.has

Reported by: vvoovv Owned by: Chris Mitchell
Priority: high Milestone: 1.7.1
Component: Dojox Version: 1.7.0
Keywords: Cc:
Blocked By: Blocking:

Description

DOMAttr.hasAttr in dojox/html/ext-dojo/style.js evaluates to undefined in IE.

It's not possible to see css3 transforms in IE because of that error. I expect demos/css3 wouldn't work in IE.

Please change DOMAttr.hasAttr to DOMAttr.has in dojox/html/ext-dojo/style.js (line 137)

Attachments (1)

dojox-html-amd.patch (1.1 KB) - added by Kenneth G. Franqueiro 8 years ago.
patch for IE errors (relative to dojox/html folder)

Download all attachments as: .zip

Change History (6)

comment:1 Changed 8 years ago by bill

Milestone: 1.7.1

Isn't it actually DOMAttr.contains()? Oh, nevermind, I'm thinking of DOMClass.contains().

Last edited 8 years ago by bill (previous) (diff)

comment:2 Changed 8 years ago by Adam Peller

Cc: Chris Mitchell removed
Owner: changed from Adam Peller to Chris Mitchell
Priority: normalhigh

comment:3 Changed 8 years ago by Kenneth G. Franqueiro

Yes, vvoovv is correct - IE < 9 encounters an error because of this in demos/css3/demo.html, and fixing this line of code resolves it.

I also noticed a stray reference to d.doc that should have been Window.doc in dojox/html/styles.js, which causes an error in IE in dojox/html/tests/test_styles.html; this is also a one-line fix.

Changed 8 years ago by Kenneth G. Franqueiro

Attachment: dojox-html-amd.patch added

patch for IE errors (relative to dojox/html folder)

comment:4 Changed 8 years ago by Kenneth G. Franqueiro

Resolution: fixed
Status: newclosed

In [27092]:

Fix IE-specific stragglers in AMD conversion of dojox/html on trunk; fixes #14272 !strict

comment:5 Changed 8 years ago by Kenneth G. Franqueiro

In [27093]:

Fix IE-specific stragglers in AMD conversion of dojox/html on 1.7 branch; fixes #14272 !strict

Note: See TracTickets for help on using tickets.