Opened 7 years ago

Closed 3 years ago

#14271 closed defect (patchwelcome)

in GFX/VML the shape of a path that has been removed then added back to the surface can't be updated

Reported by: cjolif Owned by: Eric Durocher
Priority: high Milestone: 1.13
Component: DojoX GFX Version: 1.7.0
Keywords: Cc:
Blocked By: Blocking:

Description

After removing & adding back a path to the surface if you call setShape() on it with a new shape, the path won't be correctly updated if you are running on GFX/VML.

This is working well with GFX/SVG.

See attached example (runnable from dojox/gfx/tests).

This is hurting charting when enableCache is on markers of the line chart.

Attachments (1)

test_updatePath.html (1.2 KB) - added by cjolif 7 years ago.
test case

Download all attachments as: .zip

Change History (5)

Changed 7 years ago by cjolif

Attachment: test_updatePath.html added

test case

comment:1 Changed 7 years ago by cjolif

I'm not sure at all why but it seems to come from the fact that after removing the v:shape and adding it back the "path" of shape is not anymore an element but an attribute! Which means that when in setShape we try to do this.rawNode.path.v = newpath this does nothing (as path here is the attribute not the sub-element). Changing the code to this.rawNode.path = newpath makes it work.

comment:2 Changed 7 years ago by bill

Milestone: tbd

comment:3 Changed 6 years ago by Eric Durocher

Owner: changed from Patrick Ruzand to Eric Durocher
Status: newassigned

comment:4 Changed 3 years ago by dylan

Milestone: tbd1.12
Resolution: patchwelcome
Status: assignedclosed

Given that VML is only needed for IE8 support, and is not likely to matter much longer, we have no plans to fix this. We will consider a pull request if someone wants to fix this.

Note: See TracTickets for help on using tickets.