Opened 8 years ago

Closed 8 years ago

#14256 closed defect (fixed)

Accessibility: Screen Reader IFRAME Issue

Reported by: jbest Owned by: Adam Peller
Priority: high Milestone: 1.8
Component: Dojox Version: 1.7.0
Keywords: a11y Cc: Eugene Lazutkin, Jared Jurkiewicz, Bryan Forbes
Blocked By: Blocking:

Description

dojox.html.metrics is writing out an iframe to the page. Screen reader is picking this up and reading off the html.

Attachments (1)

14256.patch (725 bytes) - added by jbest 8 years ago.

Download all attachments as: .zip

Change History (8)

Changed 8 years ago by jbest

Attachment: 14256.patch added

comment:1 Changed 8 years ago by jbest

Added a patch. Setting a display of none on the iframe (it is rendered off screen anyways) resolves the issue. You can use IE9 + Windows 7 accessibility narrator to replicate the issue (JAWS reader as well).

comment:2 Changed 8 years ago by bill

Cc: Eugene Lazutkin Jared Jurkiewicz Bryan Forbes added

Not sure who this should be assigned to.

comment:3 Changed 8 years ago by Adam Peller

Resolution: fixed
Status: newclosed

In [27022]:

Fixes #14256 a11y: iframe should not be read Thanks, jbest

comment:4 Changed 8 years ago by Adam Peller

Keywords: a11y added
Milestone: 1.8

comment:5 Changed 8 years ago by Bryan Forbes

Resolution: fixed
Status: closedreopened

Have we tried using "visibility = 'hidden'" instead of "display = 'none'"? I'd be concerned that taking the node out of rendering would cause calculations to end up wrong.

comment:6 in reply to:  5 Changed 8 years ago by jbest

Replying to BryanForbes:

Have we tried using "visibility = 'hidden'" instead of "display = 'none'"? I'd be concerned that taking the node out of rendering would cause calculations to end up wrong.

I ran all the tests after my patch. The only one failing is the html format test, which was also failing before I applied it. I changed the visibility to hidden and the screen reader is not picking it up, so either one will work OK.

comment:7 Changed 8 years ago by bill

Resolution: fixed
Status: reopenedclosed

I doublechecked that too. Turns out the iframe isn't being used for calculations, it's just being used to get notifications whenever the browser's font-size changes. Calculations are done in the main window.

Note: See TracTickets for help on using tickets.