Opened 10 years ago
Closed 10 years ago
#14256 closed defect (fixed)
Accessibility: Screen Reader IFRAME Issue
| Reported by: | jbest | Owned by: | Adam Peller |
|---|---|---|---|
| Priority: | high | Milestone: | 1.8 |
| Component: | Dojox | Version: | 1.7.0 |
| Keywords: | a11y | Cc: | Eugene Lazutkin, Jared Jurkiewicz, Bryan Forbes |
| Blocked By: | Blocking: |
Description
dojox.html.metrics is writing out an iframe to the page. Screen reader is picking this up and reading off the html.
Attachments (1)
Change History (8)
Changed 10 years ago by
| Attachment: | 14256.patch added |
|---|
comment:1 Changed 10 years ago by
comment:2 Changed 10 years ago by
| Cc: | Eugene Lazutkin Jared Jurkiewicz Bryan Forbes added |
|---|
Not sure who this should be assigned to.
comment:4 Changed 10 years ago by
| Keywords: | a11y added |
|---|---|
| Milestone: | → 1.8 |
comment:5 follow-up: 6 Changed 10 years ago by
| Resolution: | fixed |
|---|---|
| Status: | closed → reopened |
Have we tried using "visibility = 'hidden'" instead of "display = 'none'"? I'd be concerned that taking the node out of rendering would cause calculations to end up wrong.
comment:6 Changed 10 years ago by
Replying to BryanForbes:
Have we tried using "visibility = 'hidden'" instead of "display = 'none'"? I'd be concerned that taking the node out of rendering would cause calculations to end up wrong.
I ran all the tests after my patch. The only one failing is the html format test, which was also failing before I applied it. I changed the visibility to hidden and the screen reader is not picking it up, so either one will work OK.
comment:7 Changed 10 years ago by
| Resolution: | → fixed |
|---|---|
| Status: | reopened → closed |
I doublechecked that too. Turns out the iframe isn't being used for calculations, it's just being used to get notifications whenever the browser's font-size changes. Calculations are done in the main window.
Added a patch. Setting a display of none on the iframe (it is rendered off screen anyways) resolves the issue. You can use IE9 + Windows 7 accessibility narrator to replicate the issue (JAWS reader as well).