#14247 closed defect (fixed)
browser window resize doesn't resize layout widgets on IE9
Reported by: | Eric Wang | Owned by: | bill |
---|---|---|---|
Priority: | high | Milestone: | 1.6.1 |
Component: | Dijit | Version: | 1.7.0 |
Keywords: | layout | Cc: | |
Blocked By: | Blocking: |
Description
dijit layout failed on IE9.
the root cause is IE9 need to bind "onresize" event on window.global, not as IE6/7/8 bind on domNode.
the testcase file and patch as follow.
Attachments (4)
Change History (18)
Changed 9 years ago by
Attachment: | LayoutContainer.html added |
---|
comment:1 Changed 9 years ago by
Owner: | set to bill |
---|---|
Status: | new → assigned |
When you say that "dijit layout failed on IE9" what do you mean exactly? I'm guessing you mean that resizing the browser window doesn't resize the widget.
If so, good catch. I wish we could feature-test for this, but on IE9
"onresize" in document.createElement("div")
returns true even though that onresize handler never fires.
So, your fix seems good; I'll check that in... or possibly just remove the IE path altogether.
comment:7 Changed 9 years ago by
Resolution: | fixed |
---|---|
Status: | closed → reopened |
There is still a problem with same behaviour in Chrome 15, IE 9, FF 4.
If I resize window only verticaly, width of the BorderContainer? stays unchanged. Then resizing the window horizontaly causes adapting width of the BorderContainer? to the width of the window. But height stays unchanged.
The same behaviour applies for resizing the window the other way around.
I'll attach a small sample.
comment:8 Changed 9 years ago by
Milestone: | 1.7.1 → 1.7.2 |
---|---|
Summary: | dijit layout failed on IE9 → browser window resize doesn't resize layout widgets on IE9 |
Hmm, too bad, OK I'll take another look.
comment:9 Changed 9 years ago by
PS: @adros - You must work with, or are the same person as matej, this is the same format of test file he attached. Your test case is not self contained, it shouldn't reference a file called sample.js.
comment:11 Changed 9 years ago by
Milestone: | 1.7.2 → 1.7.1 |
---|---|
Priority: | high → normal |
Actually, this problem doesn't occur on the 1.7 branch / 1.7.1 tag (and I fixed trunk in the above checkin).
comment:12 Changed 8 years ago by
Milestone: | 1.7.1 → 1.6.1 |
---|
This also works just fine in 1.6, attaching the test case I used to reproduce. I don't think it needs to be backported (thankfully)!
Testcase for layout on IE9.