Opened 8 years ago

Closed 8 years ago

#14244 closed defect (fixed)

[patch][cla][meta] mdnd baseless conversion

Reported by: Mathevet julien Owned by: Adam Peller
Priority: high Milestone: 1.8
Component: Dojox Version: 1.7.0
Keywords: Cc:
Blocked By: Blocking:

Description

After converting GridContainerLite? #14235.

I just let connect.publish instead of converting to topic.publish

Attachments (2)

patchBaselessMdnd.patch (51.8 KB) - added by Mathevet julien 8 years ago.
patchBaselessMdndv2.patch (52.5 KB) - added by Mathevet julien 8 years ago.

Download all attachments as: .zip

Change History (4)

Changed 8 years ago by Mathevet julien

Attachment: patchBaselessMdnd.patch added

comment:1 Changed 8 years ago by Mathevet julien

Sorry, you need to replace in AreaManager _WidgetBase by _Widget

Tested on chromium and firefox.

But on IE, there is a bug when in getting module. I don't find why... It seems more a dojo bug on baseless than currentPatch, mid is undefined:

getModule = function(mid, referenceModule, immediate){
			// compute and optionally construct (if necessary) the module implied by the mid with respect to referenceModule
			var match, plugin, prid, result;
			match = mid.match(/^(.+?)\!(.*)$/);
Version 2, edited 8 years ago by Mathevet julien (previous) (next) (diff)

Changed 8 years ago by Mathevet julien

Attachment: patchBaselessMdndv2.patch added

comment:2 Changed 8 years ago by Adam Peller

Resolution: fixed
Status: newclosed

In [28488]:

Baseless conversion Fixes #14244 thanks, moogle !strict

Note: See TracTickets for help on using tickets.